Re: [PATCH 2/3] ASoC: cs4270: add Master Playback Switch

[Daniel Mack <daniel@caiaq.de>]

On Fri, Apr 24, 2009 at 02:17:38PM +0100, Mark Brown wrote:
> On Fri, Apr 24, 2009 at 03:00:26PM +0200, Daniel Mack wrote:
> > This new control exports cs4270's DAC MUTE capabilities.
> 
> The DAC mute is controled by cs4270_mute function - DAC mute is handles
> specially since many CODECs want to have mute synchronised with power
> down of the DAC.  If cs4270 doesn't need this then remove the DAI
> operation too.

Well, what I'm willing to implement is a way to manually mute the codec
while it is running, independendly from other ways.

I've seen that dai function and untruly believed that those two ways
could peacefully co-exist. But as it turns out, they currently influence
each other, and a manually set mute will be overridden by the next
stream start via the dai function. Which is bad.

I'll send a new patch for that, providing this feature in a slightly
more complex fashion. However, I don't want to remove the other
function. If the soc core decides to mute the codec, it should be able
to do so.

Daniel