From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "ext Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@sirena.org.uk>
Subject: Re: [PATCH 1/2] ASoC: TWL4030: Add VDL analog bypass
Date: Mon, 4 May 2009 08:29:24 +0300 [thread overview]
Message-ID: <200905040829.25180.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705F63E0BA7@dlee07.ent.ti.com>
On Friday 01 May 2009 05:47:22 ext Lopez Cruz, Misael wrote:
> This patch adds voice downlink analog bypass switch. It follows
> the same approach as in other analog bypass switches.
> DAC switch is moved from 'DAC Voice' to 'Analog Voice Playback Mixer',
> that will also allow voice DAC to be powered in digital voice
> loopback (sidetone).
>
> Signed-off-by: Misael Lopez Cruz <x0052729@ti.com>
Generally this looks good, but it would have been better if you sent this
series in three parts (now the first patch is doing two things):
0001: ASoC: TWL4030: Enable master analog loopback
0002: ASoC: TWL4030: Add VDL analog bypass
0003: ASoC: TWL4030: ASoC: TWL4030: Add voice digital loopback: sidetone
There is no mention about the master analog loopback switch in the first
patch...
Either you could resend the series or Mark can modify the commit message for
the first patch:
[PATCH 1/2] ASoC: TWL4030: Add VDL analog bypass and master loopback handling
Than to the end of the commit message:
"Handle the master analog loopback control based on the state of analog
loopback switches"
Otherwise:
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
next prev parent reply other threads:[~2009-05-04 5:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 2:47 [PATCH 1/2] ASoC: TWL4030: Add VDL analog bypass Lopez Cruz, Misael
2009-05-01 12:10 ` Mark Brown
2009-05-04 5:29 ` Peter Ujfalusi [this message]
2009-05-04 20:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200905040829.25180.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@sirena.org.uk \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox