From: Marek Vasut <marek.vasut@gmail.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: Palm27x-asoc: fix it to work without jack gpio specified
Date: Tue, 2 Jun 2009 02:11:46 +0200 [thread overview]
Message-ID: <200906020211.46536.marek.vasut@gmail.com> (raw)
In-Reply-To: <20090601225843.GA5807@sirena.org.uk>
On Tuesday 02 of June 2009 00:58:44 Mark Brown wrote:
> On Mon, Jun 01, 2009 at 10:30:58PM +0200, Marek Vasut wrote:
> > - if (!(machine_is_palmtx() || machine_is_palmt5() ||
> > - machine_is_palmld() || machine_is_palmte2()))
> > - return -ENODEV;
> > -
> > - if (pdev->dev.platform_data)
>
> These machine_is_() checks don't get re-added elsehwere (and it looks
> like you generated the diff against a different verison of the file to
> the one that's in ALSA git). It'd be better to keep them here and just
> add the { to the platform_data check.
But do we need those checks? The driver is registered only on those machines
anyway.
>
> Otherwise this is fine.
next prev parent reply other threads:[~2009-06-02 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-01 20:30 Palm27x-asoc: fix it to work without jack gpio specified Marek Vasut
2009-06-01 22:58 ` Mark Brown
2009-06-02 0:11 ` Marek Vasut [this message]
2009-06-02 9:48 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906020211.46536.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox