Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: alsa-devel@alsa-project.org
Cc: Eric Miao <eric.y.miao@gmail.com>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: [PATCH] Fix possibly incorrect offset in wm97xx-core
Date: Wed, 3 Jun 2009 23:44:37 +0200	[thread overview]
Message-ID: <200906032344.37640.marek.vasut@gmail.com> (raw)

Hi,

I just hit a problem with the accelerated (interrupt driven) ts driver. It 
stop responding after a while (sometimes right after you release a stylus off 
the touchscreen, it doesn't generate any more interrupts). I made the 
following patch that fixes the problem for me (and if I read the 9712 and 
9713 manuals correctly, the patch should be OK)

Thanks for reply.

diff --git a/drivers/input/touchscreen/wm97xx-core.c 
b/drivers/input/touchscreen/wm97xx-core.c
index 69af838..4f13a7f 100644
--- a/drivers/input/touchscreen/wm97xx-core.c
+++ b/drivers/input/touchscreen/wm97xx-core.c
@@ -307,11 +307,7 @@ static void wm97xx_pen_irq_worker(struct work_struct 
*work)
                                         WM97XX_GPIO_13);
                }

-               if (wm->id == WM9712_ID2)
-                       wm97xx_reg_write(wm, AC97_GPIO_STATUS, (status &
-                                               ~WM97XX_GPIO_13) << 1);
-               else
-                       wm97xx_reg_write(wm, AC97_GPIO_STATUS, status &
+               wm97xx_reg_write(wm, AC97_GPIO_STATUS, status &
                                                ~WM97XX_GPIO_13);
                mutex_unlock(&wm->codec_mutex);
        }

             reply	other threads:[~2009-06-03 21:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 21:44 Marek Vasut [this message]
2009-06-04  8:46 ` [PATCH] Fix possibly incorrect offset in wm97xx-core Mark Brown
2009-06-04  9:59   ` Marek Vasut
2009-06-04 11:06     ` Mark Brown
2009-06-04 20:05       ` Marek Vasut
2009-06-05  8:51         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906032344.37640.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=eric.y.miao@gmail.com \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox