From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: alsa-devel@alsa-project.org, kyungmin.park@samsung.com
Subject: Re: ASoC: MAX9877: fix write operation for register
Date: Thu, 23 Jul 2009 11:09:12 +0100 [thread overview]
Message-ID: <20090723100911.GC25013@sirena.org.uk> (raw)
In-Reply-To: <4A68204D.7040201@samsung.com>
On Thu, Jul 23, 2009 at 05:33:17PM +0900, Joonyoung Shim wrote:
> The MAX9877 needs an address of start register when we write values to
> registers through i2c_master_send(), but the code for this was missed in
> max9877_write_regs().
> If the value of control is 0 in the max9877_set_out_mode(), the value is
> not increased to 1, but actually the value to write to the register
> should be 1.
> And the register bits for out_mode and osc_mode should be cleared before
> writing.
Applied, thanks.
prev parent reply other threads:[~2009-07-23 10:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-23 8:33 ASoC: MAX9877: fix write operation for register Joonyoung Shim
2009-07-23 10:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090723100911.GC25013@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox