Re: [PATCH 1/3] ASoC: change set_tdm_slot api to allow slot_width override.

[Daniel Mack <daniel@caiaq.de>]

On Tue, Aug 04, 2009 at 09:55:45PM +0100, Mark Brown wrote:
> On Mon, Jun 15, 2009 at 09:44:31PM -0300, Daniel Ribeiro wrote:
> > Extend set_tdm_slot to allow the user to arbitrarily set the frame width
> > and active TX/RX slots.
> 
> > Updates magician.c and wm9081.c for the new set_tdm_slot(). wm9081.c
> > still doesn't handle the slot_width override.
> 
> > While being there, correct an incorrect use of SlotsPerFrm(7) use in
> > bitmask on pxa-ssp.c (SSCR0_SlotsPerFrm(x) is (((x) - 1) << 24)) ).
> 
> > (this series is meant for Mark's for-2.6.32 branch)
> 
> > Signed-off-by: Daniel Ribeiro <drwyrm@gmail.com>
> 
> So.  These have been sitting for quite some time now.  Unfortunately I
> went on holiday immediately after it was last submitted my Zylonite
> system has been bricked for pretty much all of the time since then so
> I've been remiss in following up.  Sorry about that, my bad.
> 
> My inclination here is to apply these changes - they look like a clear
> win for pretty much every machine except Daniel Mack's out of tree
> system which needs the 64 bit TDM slots.  It's a shame to break that but
> there seems to be such a clear advantage from the changes, especially
> the new set_tdm_slot() API, that it seems like a win overall.  I've got
> a feeling that the fix for that system may have to be allowing the
> machine driver to rewrite the hw_params for the CPU driver to lie about
> the data format.

Hmm. I like to stress that I appreciate the efford taken to clean up all
the API around this, and I would like to give my 'tested-by' on the
patches.

However, if it is about cleaning up things properly, we should make sure
the system does what it's been told to do, and with Daniel Ribeiro's
patches, it unfortunately doesn't yet. I'm only blaming the utterly
broken PXA register set for that, but that should be fixed before the
whole series goes in. And I'm quite sure I'm not the only user of 64 bit
TDM slots, even though I might be the only one having discussed that.

Daniel, could you resend the latest version of your patches? I hope to
find some time to again test them, find the differences in the register
bits and amend them in a way that they actually do what is needed for my
system.

And btw - the code for the system I'm working on will be release
eventually, of course, and hopefully even be merged mainline. 

Thanks,
Daniel