From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/3] new ad1836 codec driver based on asoc
Date: Thu, 13 Aug 2009 10:08:02 +0100 [thread overview]
Message-ID: <20090813090801.GA31504@sirena.org.uk> (raw)
In-Reply-To: <3c17e3570908122041m29a1843agd0f9fd0e415181c3@mail.gmail.com>
On Thu, Aug 13, 2009 at 11:41:13AM +0800, Barry Song wrote:
> On Wed, Aug 12, 2009 at 9:46 PM, Mark
> Brown<broonie@opensource.wolfsonmicro.com> wrote:
> > Just "ad1836" - the fact that it's controlled via SPI is clear from the
> > fact that this is a struct spi_driver.
> I agree the spi structure implies the meaning of spi. But files in
> arch/blackfin/mach... are using names like "xxx-spi" for almost all
> spi devices. How about keeping the coherence?
Oh dear. Looks like you've essentially got a choice between being
consistent with the rest of the world and being consistent with what the
blackfin stuff is doing.
> > The power control will be handled by DAPM but your driver still needs to
> > restore things like the volume settings - when the driver is powered off
> > the register settings will be forgotten.
> My test shows registers setting doesn't lose after dac/adc shutdown :-)
Probably your board is maintaining power to the chip even during
suspend.
next prev parent reply other threads:[~2009-08-13 9:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 4:32 [PATCH 0/3] patch sequence adds analog devices ad1836 asoc support Barry Song
2009-08-12 4:32 ` [PATCH 1/3] new ad1836 codec driver based on asoc Barry Song
2009-08-12 4:32 ` [PATCH 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot Barry Song
2009-08-12 4:32 ` [PATCH 3/3] new board driver to connect bfin-5xx with ad1836 codec Barry Song
2009-08-12 16:10 ` Mark Brown
2009-08-13 4:19 ` Barry Song
2009-08-12 13:56 ` [PATCH 2/3] add set_tdm_slot in tdm dai to define the relationship between audio channel and tdm slot Mark Brown
2009-08-13 4:16 ` Barry Song
2009-08-12 13:46 ` [PATCH 1/3] new ad1836 codec driver based on asoc Mark Brown
2009-08-13 3:41 ` Barry Song
2009-08-13 9:08 ` Mark Brown [this message]
2009-08-13 9:22 ` [Uclinux-dist-devel] " Mike Frysinger
2009-08-13 9:34 ` Mike Frysinger
2009-08-13 9:37 ` Barry Song
2009-08-13 9:46 ` Mark Brown
2009-08-13 9:52 ` Barry Song
2009-08-13 10:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813090801.GA31504@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox