From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: UDA134X Codec: Fix mute/unmute code mistake and add ADC/DAC power control support Date: Mon, 17 Aug 2009 11:32:49 +0100 Message-ID: <20090817103248.GA4464@sirena.org.uk> References: <1250498216.2764.1.camel@shinel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from cassiel.sirena.org.uk (cassiel.sirena.org.uk [80.68.93.111]) by alsa0.perex.cz (Postfix) with ESMTP id 756DC2468D for ; Mon, 17 Aug 2009 12:32:52 +0200 (CEST) Content-Disposition: inline In-Reply-To: <1250498216.2764.1.camel@shinel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Shine Liu Cc: alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org On Mon, Aug 17, 2009 at 04:36:56PM +0800, Shine Liu wrote: > There is a mistake in current uda134x_mute function: mute_reg has been > changed in line 162 or line 164, so uda134x_write should write > "mute_reg" but not "mute_reg & ~(1<<2)" to > UDA134X_DATA010. This is OK but please split it out into a separate patch and resend since... > Besides, because there is no DAPM configuration for uda134x, when system > starts up, snd_soc_int_card calls snd_soc_dapm_new_widgets, and > snd_soc_dapm_new_widgets calls dapm_power_widgets. In function > dapm_power_widgets, codec->dapm_widgets has no list entry, so sys_power > retains it's original value zero. Then ...this isn't, partly because I can't really follow what you're trying to do here. It looks awfully like you're trying to implement DAPM support - certainly things like adding the switches for DAC and ADC power shouldn't be there, they should be automatically managed in the drivers.