From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Dooks <ben@simtec.co.uk>
Cc: alsa-devel@alsa-project.org
Subject: Re: [patch 2/4] tlv320aic3x: Change to use device model
Date: Fri, 21 Aug 2009 10:49:23 +0100 [thread overview]
Message-ID: <20090821094923.GA19601@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20090820215121.748784224@fluff.org>
On Thu, Aug 20, 2009 at 10:50:41PM +0100, Ben Dooks wrote:
>
> struct aic3x_setup_data {
> - int i2c_bus;
> - unsigned short i2c_address;
> unsigned int gpio_func[2];
> };
I'll apply this but it should really be refactored to make this proper
platform data for the CODEC; that can be dealt with in a future patch.
next prev parent reply other threads:[~2009-08-21 9:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-20 21:50 [patch 0/4] ASoC S3C24XX/Simtec support Ben Dooks
2009-08-20 21:50 ` [patch 1/4] S3C24XX: Add audio core and tlv320aic23 for Simtec boards Ben Dooks
2009-08-20 21:50 ` [patch 2/4] tlv320aic3x: Change to use device model Ben Dooks
2009-08-21 9:49 ` Mark Brown [this message]
2009-08-20 21:50 ` [patch 3/4] tlv320aic3x: fixup board device changes Ben Dooks
2009-08-20 21:50 ` [patch 4/4] S3C24XX: Support for Simtec Hermes boards Ben Dooks
2009-08-21 9:53 ` [patch 0/4] ASoC S3C24XX/Simtec support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090821094923.GA19601@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben@simtec.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox