From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: alsa-devel@alsa-project.org
Cc: ext Tony Lindgren <tony@atomide.com>,
"Ujfalusi Peter (Nokia-D/Tampere)" <peter.ujfalusi@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
Linux-OMAP <linux-omap@vger.kernel.org>,
ALSA-Devel <alsa-devel@vger.kernel.org>
Subject: Re: [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2
Date: Thu, 8 Oct 2009 14:26:19 +0100 [thread overview]
Message-ID: <20091008132619.GE29176@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1255003137-1034-7-git-send-email-eduardo.valentin@nokia.com>
On Thu, Oct 08, 2009 at 02:58:55PM +0300, Eduardo Valentin wrote:
> +static struct regulator_consumer_supply rx51_vmmc2_supplies[] = {
> + REGULATOR_SUPPLY("avdd_dac", "2-0018"), /* tlv320aic3x */
> + REGULATOR_SUPPLY("vdd", "2-0060"), /* tpa6130a2*/
> };
avdd_dac is the only supply added for the tlv320aic3x but, for example,
the tlv320aic34 has something like 8 supplies from a quick scan of the
datasheet. It'd be better to set up all of the supplies, even if only
with a fixed voltage regulator supplying them, since when regulator
support is added to the CODEC driver it should be requesting all the
supplies it needs and therefore fail to instatiate if some are missing.
next prev parent reply other threads:[~2009-10-08 13:26 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1255003137-1034-1-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 11:58 ` [PATCH 1/8] ASoC: TPA6130A2 amplifier driver Eduardo Valentin
2009-10-08 11:58 ` [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver Eduardo Valentin
2009-10-08 11:58 ` [PATCH 3/8] McBSP: OMAP3: Add Sidetone feature Eduardo Valentin
2009-10-08 11:58 ` [PATCH 4/8] OMAP: RX51: Add audio board file Eduardo Valentin
2009-10-08 11:58 ` [PATCH 5/8] board-rx51-peripherals: split vaux3 and vmmc2 supplies Eduardo Valentin
2009-10-08 11:58 ` [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2 Eduardo Valentin
2009-10-08 11:58 ` [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac Eduardo Valentin
2009-10-08 11:58 ` [PATCH 8/8] ASoC: tpa6130a2: Control vdd using regulator framework Eduardo Valentin
[not found] ` <1255003137-1034-8-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 12:17 ` [PATCH 7/8] ASoC: tlv320aic3x: add initial usage of regulator framework to control avdd_dac Eero Nurkkala
[not found] ` <1255004227.30157.159.camel@eenurkka-desktop>
2009-10-08 13:17 ` Eduardo Valentin
2009-10-08 13:40 ` Mark Brown
[not found] ` <20091008134046.GH29176@rakim.wolfsonmicro.main>
2009-10-08 15:44 ` ext-Eero.Nurkkala
[not found] ` <1FFEF31EBAA4F64B80D33027D42977600E85F0CC91@NOK-EUMSG-02.mgdnok.nokia.com>
2009-10-08 16:01 ` Mark Brown
[not found] ` <1C729A43-F9F2-4FF6-A07E-5450E595982B@opensource.wolfsonmicro.com>
2009-10-09 4:28 ` Eero Nurkkala
[not found] ` <1255062483.30157.171.camel@eenurkka-desktop>
2009-10-09 10:19 ` Mark Brown
2009-10-08 13:38 ` Mark Brown
[not found] ` <1255003137-1034-2-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 12:30 ` [PATCH 1/8] ASoC: TPA6130A2 amplifier driver Eero Nurkkala
2009-10-08 12:52 ` Mark Brown
[not found] ` <1255005029.30157.164.camel@eenurkka-desktop>
2009-10-08 13:07 ` Peter Ujfalusi
[not found] ` <20091008125213.GA29176@rakim.wolfsonmicro.main>
2009-10-08 13:38 ` Peter Ujfalusi
[not found] ` <200910081638.24229.peter.ujfalusi@nokia.com>
2009-10-08 13:53 ` Mark Brown
[not found] ` <20091008135342.GJ29176@rakim.wolfsonmicro.main>
2009-10-09 6:53 ` Peter Ujfalusi
[not found] ` <200910090953.21066.peter.ujfalusi@nokia.com>
2009-10-09 10:36 ` Mark Brown
[not found] ` <1255003137-1034-3-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 12:31 ` [PATCH 2/8] ASoC: OMAP: RX-51 Machine driver and AIC34b_dummy driver Eero Nurkkala
2009-10-08 13:11 ` Mark Brown
[not found] ` <1255005086.30157.165.camel@eenurkka-desktop>
2009-10-08 13:18 ` Eduardo Valentin
[not found] ` <20091008131116.GB29176@rakim.wolfsonmicro.main>
2009-10-09 5:44 ` Jarkko Nikula
[not found] ` <20091009084400.34df690a.jhnikula@gmail.com>
2009-10-09 6:37 ` Eduardo Valentin
[not found] ` <20091009063720.GC6616@esdhcp037198.research.nokia.com>
2009-10-09 12:19 ` Mark Brown
[not found] ` <1255003137-1034-4-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 13:17 ` [PATCH 3/8] McBSP: OMAP3: Add Sidetone feature Mark Brown
[not found] ` <20091008131702.GC29176@rakim.wolfsonmicro.main>
2009-10-08 13:23 ` Eduardo Valentin
2009-10-08 13:27 ` Mark Brown
2009-10-09 5:09 ` Eero Nurkkala
2009-10-09 10:44 ` [alsa-devel] " Mark Brown
2009-10-12 6:17 ` Eero Nurkkala
2009-10-12 9:12 ` Mark Brown
2009-10-12 9:28 ` Eero Nurkkala
2009-10-12 9:32 ` Mark Brown
2009-10-12 10:28 ` Eero Nurkkala
2009-10-12 10:33 ` Mark Brown
[not found] ` <1255003137-1034-6-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 13:21 ` [PATCH 5/8] board-rx51-peripherals: split vaux3 and vmmc2 supplies Mark Brown
[not found] ` <20091008132109.GD29176@rakim.wolfsonmicro.main>
2009-10-09 6:45 ` Eduardo Valentin
[not found] ` <20091009064529.GD6616@esdhcp037198.research.nokia.com>
2009-10-09 11:03 ` Mark Brown
2009-10-12 8:08 ` Eduardo Valentin
2009-10-12 9:18 ` Mark Brown
2009-10-14 17:15 ` Tony Lindgren
2009-10-15 9:01 ` Mark Brown
2009-10-16 16:14 ` Tony Lindgren
[not found] ` <1255003137-1034-7-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 13:26 ` Mark Brown [this message]
2009-10-12 9:04 ` [PATCH 6/8] RX-51: Audio: Add usage of regulator framework to control VMMC2 Eduardo Valentin
[not found] ` <20091012090455.GC13234@esdhcp037198.research.nokia.com>
2009-10-12 9:21 ` Mark Brown
[not found] ` <20091012092104.GD3308@rakim.wolfsonmicro.main>
2009-10-19 9:13 ` Eduardo Valentin
[not found] ` <20091019091300.GA17452@esdhcp037198.research.nokia.com>
2009-10-19 9:23 ` Mark Brown
[not found] ` <20091019092332.GC23798@rakim.wolfsonmicro.main>
2009-10-19 9:24 ` Mark Brown
[not found] ` <1255003137-1034-9-git-send-email-eduardo.valentin@nokia.com>
2009-10-08 13:43 ` [PATCH 8/8] ASoC: tpa6130a2: Control vdd using regulator framework Mark Brown
2009-10-08 13:56 ` Eduardo Valentin
2009-10-08 14:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091008132619.GE29176@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=alsa-devel@vger.kernel.org \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox