From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: Graeme Gregory <gg@slimlogic.co.uk>,
alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Grazvydas Ignotas <notasas@gmail.com>,
ext Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP
Date: Mon, 9 Nov 2009 09:47:32 +0200 [thread overview]
Message-ID: <20091109094732.a5fcb6ef.jhnikula@gmail.com> (raw)
In-Reply-To: <200911090929.02019.peter.ujfalusi@nokia.com>
On Mon, 9 Nov 2009 09:29:01 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> So this patch definitely breaks McBSP slave mode.
> In case when McBSP is slave, the SRG is not in use, and there is no point of
> passing some bogus information in order to pass the test in
> omap_mcbsp_dai_hw_params introduced by this patch.
>
> I think if I set the mcbsp_data->in_freq to be:
> params_rate(params) * sample_bits * channels, and configure the mcbsp_data-
> >clk_div to be 1, might work in this case.
>
> But after this patch the beagle board and boards which has the McBSP as slave
> will stop working.
>
> I'm afraid, I can not give my Ack for this :(
>
Big thanks Peter! Me either. How on earth I didn't notice or test this
simple thing that framesize calculatation leads to zero for all other
boards than Pandora... and working Beagle audio is *must* have
feature for me...
--
Jarkko
next prev parent reply other threads:[~2009-11-09 7:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-05 21:00 [PATCH V2] ASoC - Add support for upto 16 channels on OMAP MCBSP Liam Girdwood
2009-11-06 18:24 ` Jarkko Nikula
2009-11-07 20:11 ` Grazvydas Ignotas
2009-11-08 20:27 ` Liam Girdwood
2009-11-09 6:57 ` Peter Ujfalusi
2009-11-09 6:57 ` Jarkko Nikula
2009-11-09 7:24 ` Peter Ujfalusi
2009-11-09 7:29 ` Peter Ujfalusi
2009-11-09 7:47 ` Jarkko Nikula [this message]
2009-11-09 8:14 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091109094732.a5fcb6ef.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=gg@slimlogic.co.uk \
--cc=lrg@slimlogic.co.uk \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox