From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Barry Song <21cnbao@gmail.com>
Cc: uclinux-dist-devel@blackfin.uclinux.org,
alsa-devel@alsa-project.org, Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH] soc-core: move setting ac97 platform data earlier than ac97 read/write
Date: Wed, 11 Nov 2009 11:28:18 +0000 [thread overview]
Message-ID: <20091111112818.GB18005@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1257932475-5378-1-git-send-email-21cnbao@gmail.com>
On Wed, Nov 11, 2009 at 05:41:15PM +0800, Barry Song wrote:
> While probing, AC97 codec drivers generically execute the following sequence:
> snd_soc_new_ac97_codec -> snd_soc_new_pcms -> reset ac-link/read AC97 ID to
> detect ->... -> snd_soc_init_card
>
> commit 474828a40f6ddab6e2a3475a19c5c84aa3ec7d60 adds platform_data to
> snd_ac97 instance. But ac97 platform data hasn't given to snd_ac97 until
> snd_soc_init_card. Then while ac97_read access platform_data of snd_ac97
> for detecting, NULL pointer oops will fire. That means old platform_data
> patch doesn't work in real-life cases.
>
> This patch moves the operation of setting ac97 platform_data earlier
> than ac97 reading/writing operations. Then it makes platform_data of
> AC97 become practically useful.
>
> Signed-off-by: Barry Song <21cnbao@gmail.com>
Applied, thanks.
next prev parent reply other threads:[~2009-11-11 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-11 9:41 [PATCH] soc-core: move setting ac97 platform data earlier than ac97 read/write Barry Song
2009-11-11 11:28 ` Mark Brown [this message]
2009-11-11 11:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091111112818.GB18005@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=21cnbao@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=marek.vasut@gmail.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox