Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Meerwald <pmeerw@pmeerw.net>
Cc: Vladimir Barinov <vova.barinov@gmail.com>,
	vbarinov@embeddedalley.com, alsa-devel@alsa-project.org
Subject: Re: PLL computation in TLV320AIC3x SoC driver
Date: Mon, 14 Dec 2009 10:40:21 +0000	[thread overview]
Message-ID: <20091214104021.GA20649@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <alpine.DEB.2.00.0912141116370.1905@hippogriff.cosy.sbg.ac.at>

On Mon, Dec 14, 2009 at 11:24:58AM +0100, Peter Meerwald wrote:

> +    /* try with d != 0 */
> +    for (p = 1; p <= 8; p++) {
> +
> +        j = codec_clk * p / 1000;

There are many codign style issues around the indentation in this code -
could you please run the patch through scripts/checkpatch.pl and clean
up the issues it identifies?

  reply	other threads:[~2009-12-14 10:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-08 11:28 PLL computation in TLV320AIC3x SoC driver Peter Meerwald
2009-12-08 14:46 ` Vladimir Barinov
2009-12-08 15:12   ` Peter Meerwald
2009-12-08 15:46     ` Vladimir Barinov
2009-12-08 16:05       ` Vladimir Barinov
2009-12-09 14:01         ` Peter Meerwald
2009-12-09 20:35           ` Vladimir Barinov
2009-12-14 10:24             ` Peter Meerwald
2009-12-14 10:40               ` Mark Brown [this message]
2009-12-14 13:44                 ` Peter Meerwald
2009-12-17 11:48                   ` Mark Brown
2009-12-14 10:41               ` Vladimir Barinov
2009-12-08 14:56 ` Mark Brown
2009-12-08 15:02 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091214104021.GA20649@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=pmeerw@pmeerw.net \
    --cc=vbarinov@embeddedalley.com \
    --cc=vova.barinov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox