From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26F9AC636D7 for ; Tue, 21 Feb 2023 17:02:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1E951E8A; Tue, 21 Feb 2023 18:01:59 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1E951E8A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676998969; bh=iFyDvz2P2otJwQT54nKL7jYUo8yfpArBbDhv6LjMnWo=; h=Date:Subject:To:References:From:In-Reply-To:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=TLIvWistvu6Ive6pbOifBD2P7/qiCMHFT8PStibUH433zcvDA/h4KPPUQoCJfyLBA c0XD+fyDOy0DQN/NVCT1W+KhPlBgPAUODhHScSIAbrSKVIlbz/KgKjCR+4IgE0kG12 8WUkn7B8mH5m2p0AsQLd7jSzUpE/lQXINzRncpYM= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 843DAF8057E; Tue, 21 Feb 2023 17:59:27 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 19AE5F8053D; Tue, 21 Feb 2023 17:59:14 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1C5A4F80525 for ; Tue, 21 Feb 2023 17:58:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1C5A4F80525 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=NUDB4xjA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676998743; x=1708534743; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iFyDvz2P2otJwQT54nKL7jYUo8yfpArBbDhv6LjMnWo=; b=NUDB4xjA0Mio43SRytOc8NQOmKOMWyTahBvwA5CkR3gR3UDknQypXO0R 8/V4hxIr4K36QIbS6+F3nu9ChbuCGs7j5kYXILGB/h8g8MCCYV97Bi6uS JYpzulyvF8mLaatEhZ82VsoQ1CgL6qmhiTFO+e3PrlYLvP41hZKabCKev RODoBP3v/I7uBqyKT81OrDk6Ey+O5r4zMgl7QuGFqIt7wEv7NpNljZNMy g0NpvJwjQK9jNAtuyRK/+eMWNB3661QyXgcwR7hkfmEm6+/4WQlo3HoEZ kiVPDL005LwiJi9YvJuMuLqikAnxwzGkUsU1hUcbDR43kEAnc3D592/yZ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="334884761" X-IronPort-AV: E=Sophos;i="5.97,315,1669104000"; d="scan'208";a="334884761" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 08:58:48 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10628"; a="814569146" X-IronPort-AV: E=Sophos;i="5.97,315,1669104000"; d="scan'208";a="814569146" Received: from taevough-mobl.amr.corp.intel.com (HELO [10.209.174.213]) ([10.209.174.213]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Feb 2023 08:58:47 -0800 Message-ID: <20097f1d-a7ef-9932-685c-afb22006076c@linux.intel.com> Date: Tue, 21 Feb 2023 11:52:24 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.7.1 Subject: Re: [PATCH 10/10] ASoC: Intel: soc-acpi: Add CS35L56 Soundwire to TGL Content-Language: en-US To: Richard Fitzgerald , broonie@kernel.org, cezary.rojewski@intel.com, peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com, kai.vehmanen@linux.intel.com References: <20230217161410.915202-1-rf@opensource.cirrus.com> <20230217161410.915202-11-rf@opensource.cirrus.com> From: Pierre-Louis Bossart In-Reply-To: <20230217161410.915202-11-rf@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: WZB7K5TXIETFQJUA4BL3XFLB2AVFGDPN X-Message-ID-Hash: WZB7K5TXIETFQJUA4BL3XFLB2AVFGDPN X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, patches@opensource.cirrus.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_one[] = { > + { > + .mask = BIT(0), > + .num_adr = 1, > + .adr_d = cs35l56_sdw0_adr, > + }, > + {} > +}; > + > +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_four[] = { > + { > + .mask = BIT(0), > + .num_adr = 4, > + .adr_d = cs35l56_sdw0_adr, > + }, > + {} > +}; If the machine driver has support for the 2-amplifier configuration, shouldn't it be present here as well? > + > /* this table is used when there is no I2S codec present */ > struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = { > /* mockup tests need to be first */ > @@ -501,6 +546,18 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = { > .drv_name = "sof_sdw", > .sof_tplg_filename = "sof-tgl-rt711.tplg", > }, > + { > + .link_mask = BIT(0), > + .links = up_extreme_cs35l56_sdw0_four, > + .drv_name = "sof_sdw", > + .sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg" > + }, > + { > + .link_mask = BIT(0), > + .links = up_extreme_cs35l56_sdw0_one, > + .drv_name = "sof_sdw", > + .sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg" > + }, > {}, > }; > EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_tgl_sdw_machines);