From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: "Koskinen Ilkka (Nokia-D/Tampere)" <ilkka.koskinen@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH] ASoc: tpa6130a2: Remove unnecessary variable
Date: Mon, 4 Jan 2010 14:30:36 +0200 [thread overview]
Message-ID: <201001041430.36183.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1262608203-14563-1-git-send-email-ilkka.koskinen@nokia.com>
On Monday 04 January 2010 14:30:03 Koskinen Ilkka (Nokia-D/Tampere) wrote:
> Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> ---
> sound/soc/codecs/tpa6130a2.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/tpa6130a2.c b/sound/soc/codecs/tpa6130a2.c
> index 0eb33d4..8e98ccf 100644
> --- a/sound/soc/codecs/tpa6130a2.c
> +++ b/sound/soc/codecs/tpa6130a2.c
> @@ -267,12 +267,8 @@ static const struct snd_kcontrol_new
> tpa6130a2_controls[] = { */
> static void tpa6130a2_channel_enable(u8 channel, int enable)
> {
> - struct tpa6130a2_data *data;
> u8 val;
>
> - BUG_ON(tpa6130a2_client == NULL);
> - data = i2c_get_clientdata(tpa6130a2_client);
> -
> if (enable) {
> /* Enable channel */
> /* Enable amplifier */
Yes, I think this is a leftover from some earlier code that I had.
Good catch!
Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
next prev parent reply other threads:[~2010-01-04 12:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 12:30 [PATCH] ASoc: tpa6130a2: Remove unnecessary variable Ilkka Koskinen
2010-01-04 12:30 ` Peter Ujfalusi [this message]
2010-01-04 18:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001041430.36183.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ilkka.koskinen@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox