Re: [PATCH 4/4] ASoC: Flag the i.MX SSI driver as using symmetric rates

[Sascha Hauer <s.hauer@pengutronix.de>]

Hi Mark,

On Fri, Jan 08, 2010 at 04:19:58PM +0000, Mark Brown wrote:
> While the hardware is fully asymmetric the driver currently forces
> a symmetric configuration so flag that up in the capabilities to
> avoid breakage - when the driver is able to do symmetry the flag
> can be dropped.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  sound/soc/imx/imx-ssi.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/imx/imx-ssi.c b/sound/soc/imx/imx-ssi.c
> index ccb7ec9..cfaf715 100644
> --- a/sound/soc/imx/imx-ssi.c
> +++ b/sound/soc/imx/imx-ssi.c
> @@ -357,6 +357,8 @@ static struct snd_soc_dai imx_ssi_dai = {
>  		.formats = SNDRV_PCM_FMTBIT_S16_LE,
>  	},
>  	.ops = &imx_ssi_pcm_dai_ops,
> +	/* Hardware is asymmetric but the driver isn't yet */
> +	.symmetric_rates = 1,

Why this limitation? I can successfully record with 16000Hz while
playing at 48000Hz on my PCM037 board. What is missing in the driver to
'officially' support asymmetric rates?

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |