Re: [PATCH] - fix speaker output for toshiba nb205 netbooks

[Nickolas <ultrageek.lloyd@gmail.com>]

On Wed, 13 Jan 2010 17:17:20 +0100
Takashi Iwai <tiwai@suse.de> wrote:

> At Wed, 13 Jan 2010 11:06:11 -0500,
> Nickolas wrote:
> > 
> > On Wed, 13 Jan 2010 09:14:32 +0100
> > Takashi Iwai <tiwai@suse.de> wrote:
> > 
> > > At Tue, 12 Jan 2010 16:58:32 -0500,
> > > Nickolas wrote:
> > > > 
> > > > this is a quick fix i wrote up a couple days ago to fix speaker
> > > > output on the Realtek ALC272 codec present in toshiba nb205
> > > > netbooks.  presently, speaker output doesn't work at all on this
> > > > model, regardless of settings in the mixer.  this is because the
> > > > current driver thinks the speaker is at nid 0x0c instead of the
> > > > correct 0x17.  i'm not too familiar with this hardware, so i'm not
> > > > sure that this patch won't have any negative effects for other
> > > > hardware.  it also seems like a messy way of fixing the problem.
> > > > any comments or suggestions are welcome, as is testing for those who
> > > > have this board.  diffed against the latest git.
> > > 
> > > Thanks for the patch.  The change looks safe to me.
> > > 
> > > But I'm still wondering whether model=auto doesn't work for this device.
> > > Could you try it with the latest driver?
> > > 
> > > 
> > > thanks,
> > > 
> > > Takashi
> > > 
> > 
> > hmm, i feel stupid.  so, it works with model=auto, but why is that not implied when the model parameter isn't specified on the command line?
> 
> OK, that's good to hear.  IIRC, the quirk was there because it didn't work
> with model=auto, at least, at that time.
> 
> I guess it's time to back to auto option again.  I'll fix now.
> 
> Thanks for quick testing!
> 
> 
> Takashi

no problem.  i'll test all the ports later today when i have time to make sure that they work properly with model=auto, just to be sure.  thanks for the help!

Nick