* [PATCH] ASoC: DaVinci: Fix stream restart error
@ 2010-01-20 11:36 Chaithrika U S
2010-01-26 12:42 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Chaithrika U S @ 2010-01-20 11:36 UTC (permalink / raw)
To: alsa-devel; +Cc: khilman, Chaithrika U S, davinci-linux-open-source, broonie
Sometimes after a suspend-resume cycle, the ALSA application
restarts the stream when resume fails and McASP fails to work
as the clock is not enabled. This patch corrects this bug.
Testes on TI DA850/OMAP-L138 EVM.
Signed-off-by: Chaithrika U S <chaithrika@ti.com>
---
Applies to ALSA GIT tree on branch topic/asoc at
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=shortlog;
h=topic/asoc
sound/soc/davinci/davinci-mcasp.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
index a613bbb..ab6518d 100644
--- a/sound/soc/davinci/davinci-mcasp.c
+++ b/sound/soc/davinci/davinci-mcasp.c
@@ -768,13 +768,12 @@ static int davinci_mcasp_trigger(struct snd_pcm_substream *substream,
switch (cmd) {
case SNDRV_PCM_TRIGGER_RESUME:
+ case SNDRV_PCM_TRIGGER_START:
+ case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (!dev->clk_active) {
clk_enable(dev->clk);
dev->clk_active = 1;
}
- /* Fall through */
- case SNDRV_PCM_TRIGGER_START:
- case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
davinci_mcasp_start(dev, substream->stream);
break;
--
1.5.6
^ permalink raw reply related [flat|nested] 3+ messages in thread[parent not found: <1263987285-29775-1-git-send-email-alsa-devel@alsa-project.org>]
* Re: [PATCH] ASoC: DaVinci: Fix stream restart error
[not found] <1263987285-29775-1-git-send-email-alsa-devel@alsa-project.org>
@ 2010-01-20 12:07 ` Chaithrika U S
0 siblings, 0 replies; 3+ messages in thread
From: Chaithrika U S @ 2010-01-20 12:07 UTC (permalink / raw)
To: alsa-devel; +Cc: khilman, davinci-linux-open-source, broonie
All,
Please ignore this patch, missed the 'To' address in the mail.
I have re-submitted this patch.
Regards,
Chaithrika
On Wed, Jan 20, 2010 at 17:04:45, alsa-devel@alsa-project.org wrote:
> From: Chaithrika U S <chaithrika@ti.com>
>
> Sometimes after a suspend-resume cycle, the ALSA application
> restarts the stream when resume fails and McASP fails to work
> as the clock is not enabled. This patch corrects this bug.
>
> Testes on TI DA850/OMAP-L138 EVM.
>
> Signed-off-by: Chaithrika U S <chaithrika@ti.com>
> ---
> Applies to ALSA GIT tree on branch topic/asoc at
> http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-2.6.git;a=shortlog;
> h=topic/asoc
>
> sound/soc/davinci/davinci-mcasp.c | 5 ++---
> 1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-mcasp.c b/sound/soc/davinci/davinci-mcasp.c
> index a613bbb..ab6518d 100644
> --- a/sound/soc/davinci/davinci-mcasp.c
> +++ b/sound/soc/davinci/davinci-mcasp.c
> @@ -768,13 +768,12 @@ static int davinci_mcasp_trigger(struct snd_pcm_substream *substream,
>
> switch (cmd) {
> case SNDRV_PCM_TRIGGER_RESUME:
> + case SNDRV_PCM_TRIGGER_START:
> + case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> if (!dev->clk_active) {
> clk_enable(dev->clk);
> dev->clk_active = 1;
> }
> - /* Fall through */
> - case SNDRV_PCM_TRIGGER_START:
> - case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> davinci_mcasp_start(dev, substream->stream);
> break;
>
> --
> 1.5.6
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-26 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-20 11:36 [PATCH] ASoC: DaVinci: Fix stream restart error Chaithrika U S
2010-01-26 12:42 ` Mark Brown
[not found] <1263987285-29775-1-git-send-email-alsa-devel@alsa-project.org>
2010-01-20 12:07 ` Chaithrika U S
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).