Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"ext Candelaria Villareal, Jorge" <x0107209@ti.com>,
	"broonie@opensource.wolfsonmicro.com"
	<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv2 1/6] ASoC: OMAP: data_type and sync_mode configurable in audio dma
Date: Wed, 27 Jan 2010 09:06:52 +0200	[thread overview]
Message-ID: <201001270906.52775.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <2256F256009DAA4CBE661E9F41EAC84B8C43A8AD@dlee01.ent.ti.com>

On Saturday 23 January 2010 01:14:59 ext Candelaria Villareal, Jorge wrote:
> From: Misael Lopez Cruz <x0052729@ti.com>
> 
> Allow client drivers to set the data_type (16, 32) and the
> sync_mode (element, packet, etc) of the audio dma transferences.
> 
> McBSP dai driver configures it for a data type of 16 bits and
> element sync mode.

Since the mcbsp code itself is hardwired for 16bit samples (at the moment), I 
think it would be better to add constraint in omap-pcm.c to make it explicit 
that only S16_LE is supported.

-- 
Péter

      parent reply	other threads:[~2010-01-27  7:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 23:14 [PATCHv2 1/6] ASoC: OMAP: data_type and sync_mode configurable in audio dma Candelaria Villareal, Jorge
2010-01-23  0:56 ` Liam Girdwood
2010-01-25 21:06   ` [alsa-devel] " Candelaria Villareal, Jorge
2010-01-27  7:06 ` Peter Ujfalusi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201001270906.52775.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=x0107209@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox