From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: jassisinghbrar@gmail.com
Cc: alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
Jassi Brar <jassi.brar@samsung.com>,
ben-linux@fluff.org, linux-arm-kernel@lists.infradead.org,
lrg@slimlogic.co.uk
Subject: Re: [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver
Date: Thu, 28 Jan 2010 12:00:26 +0000 [thread overview]
Message-ID: <20100128120020.GA19270@sirena.org.uk> (raw)
In-Reply-To: <1264571959-15115-1-git-send-email-jassisinghbrar@gmail.com>
On Wed, Jan 27, 2010 at 02:59:19PM +0900, jassisinghbrar@gmail.com wrote:
> + Headphone Playback Switch - On
> + $ amixer cset numid=4 1
> +
Actually, one thing that really needs fixing here - these instructions
refer to the controls by number. This is extremely fragile in the face
of any changes in the CODEC driver since the control numbering is worked
out at runtime and any change in the set of controls exported by the
device may change the result. It is much better to refer to the
controls by name since the names are much less likely to change. This
is also helpful for people using other UIs which don't display the
control names.
next prev parent reply other threads:[~2010-01-28 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 5:59 [PATCHv2 05/10] ASoC: AC97: SMDK: Add wm9713 machine driver jassisinghbrar
2010-01-28 12:00 ` Mark Brown [this message]
2010-01-29 1:08 ` [alsa-devel] " jassi brar
2010-01-29 9:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100128120020.GA19270@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=ben-linux@fluff.org \
--cc=jassi.brar@samsung.com \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).