* [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function
@ 2010-01-29 8:28 Anuj Aggarwal
2010-01-29 11:00 ` [alsa-devel] " Liam Girdwood
2010-01-29 13:44 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Anuj Aggarwal @ 2010-01-29 8:28 UTC (permalink / raw)
To: alsa-devel, linux-omap; +Cc: Anuj Aggarwal, broonie
Commit e9ff5eb2 (Fixing infinite loop in resume path) uses wrong AIC23
register in resume function because of which register writes happen
on some non-existing registers.
Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
---
sound/soc/codecs/tlv320aic23.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/soc/codecs/tlv320aic23.c b/sound/soc/codecs/tlv320aic23.c
index a9dc5fb..da589d8 100644
--- a/sound/soc/codecs/tlv320aic23.c
+++ b/sound/soc/codecs/tlv320aic23.c
@@ -627,7 +627,7 @@ static int tlv320aic23_resume(struct platform_device *pdev)
u16 reg;
/* Sync reg_cache with the hardware */
- for (reg = 0; reg < TLV320AIC23_RESET; reg++) {
+ for (reg = 0; reg <= TLV320AIC23_ACTIVE; reg++) {
u16 val = tlv320aic23_read_reg_cache(codec, reg);
tlv320aic23_write(codec, reg, val);
}
--
1.6.2.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [alsa-devel] [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function
2010-01-29 8:28 [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function Anuj Aggarwal
@ 2010-01-29 11:00 ` Liam Girdwood
2010-01-29 13:44 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-01-29 11:00 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: alsa-devel, linux-omap, broonie
On Fri, 2010-01-29 at 13:58 +0530, Anuj Aggarwal wrote:
> Commit e9ff5eb2 (Fixing infinite loop in resume path) uses wrong AIC23
> register in resume function because of which register writes happen
> on some non-existing registers.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function
2010-01-29 8:28 [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function Anuj Aggarwal
2010-01-29 11:00 ` [alsa-devel] " Liam Girdwood
@ 2010-01-29 13:44 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-01-29 13:44 UTC (permalink / raw)
To: Anuj Aggarwal; +Cc: alsa-devel, linux-omap
On Fri, Jan 29, 2010 at 01:58:55PM +0530, Anuj Aggarwal wrote:
> Commit e9ff5eb2 (Fixing infinite loop in resume path) uses wrong AIC23
> register in resume function because of which register writes happen
> on some non-existing registers.
>
> Signed-off-by: Anuj Aggarwal <anuj.aggarwal@ti.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-29 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-29 8:28 [PATCH 1/1] ASoC: AIC23: Fixing writes to non-existing registers in resume function Anuj Aggarwal
2010-01-29 11:00 ` [alsa-devel] " Liam Girdwood
2010-01-29 13:44 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).