From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Daniel Mack <daniel@caiaq.de>
Cc: alsa-devel@alsa-project.org, Eric Miao <eric.y.miao@gmail.com>,
Philipp Zabel <philipp.zabel@gmail.com>
Subject: Re: [PATCH] ALSA: ASoC: fix PXA SSP port resume
Date: Fri, 29 Jan 2010 14:00:01 +0000 [thread overview]
Message-ID: <20100129140001.GB4768@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100129110836.GV28972@buzzloop.caiaq.de>
On Fri, Jan 29, 2010 at 12:08:36PM +0100, Daniel Mack wrote:
> And as the next client will indirectly call hw_params() again, the code
> there will do the right thing with the invalidated cache.
Yeah, I know the code is actually reasonably safe - it just doesn't give
me the warm and fuzzies to do the invalidation by programming a random
value in there simply on the off chance that at some point in the future
that winds up being a valid value and so the same problem recurs.
> Restoring the register values from priv->dai_fmt would imply adding code
> to do everything what the other bit-fiddling functions do in a reverse
> manner. Which is something I'd like to avoid :)
Oh, right. I'd forgotten that that was what it was actually storing.
> Another idea is to unconditionally save and restore the register set,
> and deal with possible side-effects. Not sure what's really better.
I think that'd be the the most robust solution with the way things are
structured in the driver.
next prev parent reply other threads:[~2010-01-29 14:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 10:34 [PATCH] ALSA: ASoC: fix PXA SSP port resume Daniel Mack
2010-01-29 10:13 ` Mark Brown
2010-01-29 11:08 ` Daniel Mack
2010-01-29 14:00 ` Mark Brown [this message]
2010-02-02 3:32 ` Daniel Mack
2010-02-02 10:51 ` Liam Girdwood
2010-02-02 10:45 ` Daniel Mack
2010-02-02 11:41 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129140001.GB4768@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=daniel@caiaq.de \
--cc=eric.y.miao@gmail.com \
--cc=philipp.zabel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).