* [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset
@ 2010-01-29 1:57 jassisinghbrar
2010-01-29 10:58 ` Liam Girdwood
2010-01-29 14:03 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: jassisinghbrar @ 2010-01-29 1:57 UTC (permalink / raw)
To: alsa-devel; +Cc: broonie, Jassi Brar, ben-linux, lrg
From: Jassi Brar <jassi.brar@samsung.com>
It's more robust when references are provided in control names
rather than numid.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
sound/soc/s3c24xx/smdk_wm9713.c | 23 +++++++----------------
1 files changed, 7 insertions(+), 16 deletions(-)
diff --git a/sound/soc/s3c24xx/smdk_wm9713.c b/sound/soc/s3c24xx/smdk_wm9713.c
index 6fa2c9d..24fd39f 100644
--- a/sound/soc/s3c24xx/smdk_wm9713.c
+++ b/sound/soc/s3c24xx/smdk_wm9713.c
@@ -29,24 +29,15 @@ static struct snd_soc_card smdk;
/*
Playback (HeadPhone):-
- Headphone Playback Switch - On
- $ amixer cset numid=4 1
-
- Right Headphone Out Mux - Headphone
- $ amixer cset numid=92 2
- Left Headphone Out Mux - Headphone
- $ amixer cset numid=93 2
-
- Right HP Mixer PCM Playback Switch - On
- $ amixer cset numid=75 1
- Left HP Mixer PCM Playback Switch - On
- $ amixer cset numid=81 1
+ $ amixer sset 'Headphone' unmute
+ $ amixer sset 'Right Headphone Out Mux' 'Headphone'
+ $ amixer sset 'Left Headphone Out Mux' 'Headphone'
+ $ amixer sset 'Right HP Mixer PCM' unmute
+ $ amixer sset 'Left HP Mixer PCM' unmute
Capture (LineIn):-
- Right Capture Source - Line
- $ amixer cset numid=86 2
- Left Capture Source - Line
- $ amixer cset numid=87 2
+ $ amixer sset 'Right Capture Source' 'Line'
+ $ amixer sset 'Left Capture Source' 'Line'
*/
static struct snd_soc_dai_link smdk_dai = {
--
1.6.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset
2010-01-29 1:57 [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset jassisinghbrar
@ 2010-01-29 10:58 ` Liam Girdwood
2010-01-29 14:03 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-01-29 10:58 UTC (permalink / raw)
To: jassisinghbrar; +Cc: alsa-devel, broonie, ben-linux, Jassi Brar
On Fri, 2010-01-29 at 10:57 +0900, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> It's more robust when references are provided in control names
> rather than numid.
>
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> sound/soc/s3c24xx/smdk_wm9713.c | 23 +++++++----------------
> 1 files changed, 7 insertions(+), 16 deletions(-)
Btw, I have some time to finish the alsalib use case manager now, so
this should further simplify your signal routing to userspace when
completed.
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset
2010-01-29 1:57 [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset jassisinghbrar
2010-01-29 10:58 ` Liam Girdwood
@ 2010-01-29 14:03 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-01-29 14:03 UTC (permalink / raw)
To: jassisinghbrar; +Cc: alsa-devel, Jassi Brar, ben-linux, lrg
On Fri, Jan 29, 2010 at 10:57:07AM +0900, jassisinghbrar@gmail.com wrote:
> From: Jassi Brar <jassi.brar@samsung.com>
>
> It's more robust when references are provided in control names
> rather than numid.
>
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-01-29 14:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-29 1:57 [PATCH] ASoC: AC97: SMDK-WM9713: Convert notes from cset to sset jassisinghbrar
2010-01-29 10:58 ` Liam Girdwood
2010-01-29 14:03 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).