From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v2] ASoC: clean up wm8974 and wm8978 clock divider handling
Date: Fri, 29 Jan 2010 14:33:41 +0000 [thread overview]
Message-ID: <20100129143340.GA7123@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <Pine.LNX.4.64.1001291526000.4613@axis700.grange>
On Fri, Jan 29, 2010 at 03:31:06PM +0100, Guennadi Liakhovetski wrote:
> wm8974 and wm8978 codec drivers control DAC and ADC oversampling rates in their
> .set_clkdiv() methods, which is wrong, because these are simple boolean
> switches and not clock dividers. Move these bits to sound controls. Also remove
> manual configuration of the MCLK divider in wm8978, since it is configured
> automatically.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Applied, thanks.
prev parent reply other threads:[~2010-01-29 14:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 14:31 [PATCH v2] ASoC: clean up wm8974 and wm8978 clock divider handling Guennadi Liakhovetski
2010-01-29 14:33 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100129143340.GA7123@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=g.liakhovetski@gmx.de \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).