From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH v2] ASoC: clean up wm8974 and wm8978 clock divider handling Date: Fri, 29 Jan 2010 14:33:41 +0000 Message-ID: <20100129143340.GA7123@rakim.wolfsonmicro.main> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id EFC55103934 for ; Fri, 29 Jan 2010 15:33:41 +0100 (CET) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Guennadi Liakhovetski Cc: alsa-devel@alsa-project.org, Liam Girdwood List-Id: alsa-devel@alsa-project.org On Fri, Jan 29, 2010 at 03:31:06PM +0100, Guennadi Liakhovetski wrote: > wm8974 and wm8978 codec drivers control DAC and ADC oversampling rates in their > .set_clkdiv() methods, which is wrong, because these are simple boolean > switches and not clock dividers. Move these bits to sound controls. Also remove > manual configuration of the MCLK divider in wm8978, since it is configured > automatically. > > Signed-off-by: Guennadi Liakhovetski Applied, thanks.