From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Peter Ujfalusi <peter.ujfalusi@Nokia.com>,
ext Grazvydas Ignotas <notasas@gmail.com>
Subject: Re: [PATCH] ASoC: pandora: Add APLL supply to fix audio output
Date: Fri, 5 Feb 2010 12:35:57 +0000 [thread overview]
Message-ID: <20100205123556.GA18234@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1265364801.3177.6.camel@odin>
On Fri, Feb 05, 2010 at 10:13:21AM +0000, Liam Girdwood wrote:
> On Fri, 2010-02-05 at 08:50 +0200, Peter Ujfalusi wrote:
> > On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote:
> > > Pandora's external DAC is using 256*Fs output from the TWL4030
> > > codec, and TWL4030 needs to have APLL enabled for it's 256*Fs
> > > output to function.
> > >
> > > Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
> > > ---
> > > I noticed this a bit late because TWL4030 codec used to have APLL
> > > enable hardcoded until that was clean up by not-so-old patch.
> > > Would be nice to see this in next -rc, as without this audio
> > > won't work completely on pandora (again)..
> >
> > Yeah, when I made the changes to the twl4030 codec, I did missed the pandora
> > setup..
> >
> > Acked-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
>
> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
Applied, thanks.
prev parent reply other threads:[~2010-02-05 12:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 22:55 [PATCH] ASoC: pandora: Add APLL supply to fix audio output Grazvydas Ignotas
2010-02-05 6:50 ` Peter Ujfalusi
2010-02-05 10:13 ` Liam Girdwood
2010-02-05 12:35 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205123556.GA18234@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=notasas@gmail.com \
--cc=peter.ujfalusi@Nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).