From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH] ASoC: pandora: Add APLL supply to fix audio output Date: Fri, 5 Feb 2010 12:35:57 +0000 Message-ID: <20100205123556.GA18234@rakim.wolfsonmicro.main> References: <1265324133-23607-1-git-send-email-notasas@gmail.com> <201002050850.56430.peter.ujfalusi@nokia.com> <1265364801.3177.6.camel@odin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id EF6A21037F7 for ; Fri, 5 Feb 2010 13:35:59 +0100 (CET) Content-Disposition: inline In-Reply-To: <1265364801.3177.6.camel@odin> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Liam Girdwood Cc: "alsa-devel@alsa-project.org" , Peter Ujfalusi , ext Grazvydas Ignotas List-Id: alsa-devel@alsa-project.org On Fri, Feb 05, 2010 at 10:13:21AM +0000, Liam Girdwood wrote: > On Fri, 2010-02-05 at 08:50 +0200, Peter Ujfalusi wrote: > > On Friday 05 February 2010 00:55:33 ext Grazvydas Ignotas wrote: > > > Pandora's external DAC is using 256*Fs output from the TWL4030 > > > codec, and TWL4030 needs to have APLL enabled for it's 256*Fs > > > output to function. > > > > > > Signed-off-by: Grazvydas Ignotas > > > --- > > > I noticed this a bit late because TWL4030 codec used to have APLL > > > enable hardcoded until that was clean up by not-so-old patch. > > > Would be nice to see this in next -rc, as without this audio > > > won't work completely on pandora (again).. > > > > Yeah, when I made the changes to the twl4030 codec, I did missed the pandora > > setup.. > > > > Acked-by: Peter Ujfalusi > > Acked-by: Liam Girdwood Applied, thanks.