From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Grazvydas Ignotas <notasas@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH -next] ASoC: pandora: Add DAC regulator support
Date: Fri, 5 Feb 2010 17:20:31 +0000 [thread overview]
Message-ID: <20100205172031.GA31523@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <6ed0b2681002050629p1d38c19m19d1a124ddce307a@mail.gmail.com>
On Fri, Feb 05, 2010 at 04:29:53PM +0200, Grazvydas Ignotas wrote:
> Uh, I meant "no audible improvement". However I've just checked the
> DAC datasheet again and it requires 1ms delay between turning on/off
> the supply and switching /PD pin (connected to
> OMAP3_PANDORA_DAC_POWER_GPIO). Even though I hear no difference,
> adding the delays back just in case. Updated patch attached.
Which step of the powerup is the one that generates the pop? As Liam
says if you can mute the DAC while powering up might help if that's
possible, though looking I don't think it is.
> From 72cdf36e432a9929baff8841df979f13492dc813 Mon Sep 17 00:00:00 2001
> From: Grazvydas Ignotas <notasas@gmail.com>
> Date: Fri, 5 Feb 2010 12:57:37 +0200
> Subject: [PATCH -next] ASoC: pandora: Add DAC regulator support
Please don't append patches to messages like this, it makes them harder
to apply since the e-mail text ends up as part of the commit message as
does the patch header.
Applied, thanks.
next prev parent reply other threads:[~2010-02-05 17:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 13:13 [PATCH -next] ASoC: pandora: Add DAC regulator support Grazvydas Ignotas
2010-02-05 14:08 ` Liam Girdwood
2010-02-05 14:29 ` Grazvydas Ignotas
2010-02-05 15:16 ` Liam Girdwood
2010-02-05 17:20 ` Mark Brown [this message]
2010-02-06 17:33 ` Grazvydas Ignotas
2010-02-07 9:07 ` Jarkko Nikula
2010-02-08 12:29 ` Grazvydas Ignotas
2010-02-08 11:39 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205172031.GA31523@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).