* [PATCH V2 3/4] Add ASoC support for Devkit8000
@ 2010-02-09 16:08 Thomas Weber
2010-02-09 16:33 ` Jarkko Nikula
0 siblings, 1 reply; 2+ messages in thread
From: Thomas Weber @ 2010-02-09 16:08 UTC (permalink / raw)
To: alsa-devel; +Cc: Thomas Weber
This patch expands the omap3beagle sound soc for the
beagle board clone DevKit8000.
Signed-off-by: Thomas Weber <weber@corscience.de>
---
sound/soc/omap/Kconfig | 8 +++++---
sound/soc/omap/omap3beagle.c | 6 +++---
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/sound/soc/omap/Kconfig b/sound/soc/omap/Kconfig
index 61952aa..1cdd541 100644
--- a/sound/soc/omap/Kconfig
+++ b/sound/soc/omap/Kconfig
@@ -94,12 +94,14 @@ config SND_OMAP_SOC_OMAP3_PANDORA
Say Y if you want to add support for SoC audio on the OMAP3 Pandora.
config SND_OMAP_SOC_OMAP3_BEAGLE
- tristate "SoC Audio support for OMAP3 Beagle"
- depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP3_BEAGLE
+ tristate "SoC Audio support for OMAP3 Beagle and Devkit8000"
+ depends on TWL4030_CORE && SND_OMAP_SOC
+ depends on (MACH_OMAP3_BEAGLE || MACH_DEVKIT8000)
select SND_OMAP_SOC_MCBSP
select SND_SOC_TWL4030
help
- Say Y if you want to add support for SoC audio on the Beagleboard.
+ Say Y if you want to add support for SoC audio on the Beagleboard or
+ the clone Devkit8000.
config SND_OMAP_SOC_ZOOM2
tristate "SoC Audio support for Zoom2"
diff --git a/sound/soc/omap/omap3beagle.c b/sound/soc/omap/omap3beagle.c
index d88ad5c..240e097 100644
--- a/sound/soc/omap/omap3beagle.c
+++ b/sound/soc/omap/omap3beagle.c
@@ -117,11 +117,11 @@ static int __init omap3beagle_soc_init(void)
{
int ret;
- if (!machine_is_omap3_beagle()) {
- pr_debug("Not OMAP3 Beagle!\n");
+ if (!(machine_is_omap3_beagle() || machine_is_devkit8000())) {
+ pr_debug("Not OMAP3 Beagle or Devkit8000!\n");
return -ENODEV;
}
- pr_info("OMAP3 Beagle SoC init\n");
+ pr_info("OMAP3 Beagle/Devkit8000 SoC init\n");
omap3beagle_snd_device = platform_device_alloc("soc-audio", -1);
if (!omap3beagle_snd_device) {
--
1.6.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH V2 3/4] Add ASoC support for Devkit8000
2010-02-09 16:08 [PATCH V2 3/4] Add ASoC support for Devkit8000 Thomas Weber
@ 2010-02-09 16:33 ` Jarkko Nikula
0 siblings, 0 replies; 2+ messages in thread
From: Jarkko Nikula @ 2010-02-09 16:33 UTC (permalink / raw)
To: Thomas Weber; +Cc: alsa-devel
Hi
On Tue, 9 Feb 2010 17:08:48 +0100
Thomas Weber <weber@corscience.de> wrote:
> config SND_OMAP_SOC_OMAP3_BEAGLE
> - tristate "SoC Audio support for OMAP3 Beagle"
> - depends on TWL4030_CORE && SND_OMAP_SOC && MACH_OMAP3_BEAGLE
> + tristate "SoC Audio support for OMAP3 Beagle and Devkit8000"
> + depends on TWL4030_CORE && SND_OMAP_SOC
> + depends on (MACH_OMAP3_BEAGLE || MACH_DEVKIT8000)
> select SND_OMAP_SOC_MCBSP
> select SND_SOC_TWL4030
> help
> - Say Y if you want to add support for SoC audio on the Beagleboard.
> + Say Y if you want to add support for SoC audio on the Beagleboard or
> + the clone Devkit8000.
>
I was thinking here that would it be better to have own Kconfig option
for the Devkit8000 already now? I don't know the Devkit8000 but it makes
easier to maintain e.g. defconfigs if there is ever need to separate
audio functionality, select statements, etc. of these two board.
--
Jarkko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-09 16:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 16:08 [PATCH V2 3/4] Add ASoC support for Devkit8000 Thomas Weber
2010-02-09 16:33 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).