* [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration
@ 2010-02-17 7:49 Peter Ujfalusi
2010-02-17 10:53 ` Liam Girdwood
2010-02-17 13:43 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Peter Ujfalusi @ 2010-02-17 7:49 UTC (permalink / raw)
To: alsa-devel; +Cc: broonie, lrg
Disable the amplifiers for the headset outputs, and do not select
routings by default to the headset outputs.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
---
The obvious side effect of this patch is that on boards which are using the
headset output the playback will not work 'out of box'.
The user need to specifically enable the routings for the boards.
Board that came to my mind is the Beagle, and probably it's clones as well.
sound/soc/codecs/twl4030.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/twl4030.c b/sound/soc/codecs/twl4030.c
index 277862e..6f5d4af 100644
--- a/sound/soc/codecs/twl4030.c
+++ b/sound/soc/codecs/twl4030.c
@@ -75,8 +75,8 @@ static const u8 twl4030_reg[TWL4030_CACHEREGNUM] = {
0x00, /* REG_BTPGA (0x1F) */
0x00, /* REG_BTSTPGA (0x20) */
0x00, /* REG_EAR_CTL (0x21) */
- 0x24, /* REG_HS_SEL (0x22) */
- 0x0a, /* REG_HS_GAIN_SET (0x23) */
+ 0x00, /* REG_HS_SEL (0x22) */
+ 0x00, /* REG_HS_GAIN_SET (0x23) */
0x00, /* REG_HS_POPN_SET (0x24) */
0x00, /* REG_PREDL_CTL (0x25) */
0x00, /* REG_PREDR_CTL (0x26) */
--
1.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration
2010-02-17 7:49 [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration Peter Ujfalusi
@ 2010-02-17 10:53 ` Liam Girdwood
2010-02-17 13:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2010-02-17 10:53 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, broonie
On Wed, 2010-02-17 at 09:49 +0200, Peter Ujfalusi wrote:
> Disable the amplifiers for the headset outputs, and do not select
> routings by default to the headset outputs.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
> ---
>
> The obvious side effect of this patch is that on boards which are using the
> headset output the playback will not work 'out of box'.
> The user need to specifically enable the routings for the boards.
> Board that came to my mind is the Beagle, and probably it's clones as well.
>
> sound/soc/codecs/twl4030.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration
2010-02-17 7:49 [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration Peter Ujfalusi
2010-02-17 10:53 ` Liam Girdwood
@ 2010-02-17 13:43 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-02-17 13:43 UTC (permalink / raw)
To: Peter Ujfalusi; +Cc: alsa-devel, lrg
On Wed, Feb 17, 2010 at 09:49:54AM +0200, Peter Ujfalusi wrote:
> Disable the amplifiers for the headset outputs, and do not select
> routings by default to the headset outputs.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-17 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-17 7:49 [PATCH] ASoC: TWL4030: Use codec defaults for Headset initial configuration Peter Ujfalusi
2010-02-17 10:53 ` Liam Girdwood
2010-02-17 13:43 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).