From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org,
"Koskinen Ilkka (Nokia-D/Tampere)" <ilkka.koskinen@nokia.com>,
"tony@atomide.com" <tony@atomide.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature
Date: Thu, 18 Feb 2010 17:41:30 +0200 [thread overview]
Message-ID: <20100218174130.9bab289e.jhnikula@gmail.com> (raw)
In-Reply-To: <201002181556.03245.peter.ujfalusi@nokia.com>
On Thu, 18 Feb 2010 15:56:03 +0200
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > Are you sure about these ids? Same comment to the patch 2 as well.
> > Worth to check.
>
> They are correct.
> mcbsp->id is 1 based (1 -> McBSP1, 2 -> McBSP2, etc)
> While the exported functions expect the id to
> be 0 based (0 -> McBSP1, 1 -> McBSP2, etc)
>
> But, yes it is confusing at times...
>
Definitely. As existing API is using 0 based indexing, it's better to
use here as well. That would make the lines like below simpler too :-)
+ return omap_st_set_chgain((id)-1, val, 0, channel);
--
Jarkko
prev parent reply other threads:[~2010-02-18 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-18 12:37 [PATCHv2 0/2] McBSP: OMAP3: Add sidetone feature Ilkka Koskinen
2010-02-18 12:37 ` [PATCHv3 1/2] " Ilkka Koskinen
2010-02-18 12:37 ` [PATCHv3 2/2] ASoC: OMAP-McBSP: ASoC interface for McBSP sidetone Ilkka Koskinen
2010-02-18 14:11 ` Peter Ujfalusi
2010-02-18 17:16 ` [alsa-devel] " Ilkka Koskinen
2010-02-18 13:24 ` [PATCHv3 1/2] McBSP: OMAP3: Add sidetone feature Jarkko Nikula
2010-02-18 13:56 ` Peter Ujfalusi
2010-02-18 15:41 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218174130.9bab289e.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=ilkka.koskinen@nokia.com \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).