From: Dan Carpenter <error27@gmail.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>,
kernel-janitors@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>
Subject: [patch] oxygen: clean up. make precedence explicit
Date: Fri, 19 Feb 2010 09:58:56 +0300 [thread overview]
Message-ID: <20100219065856.GA17130@bicker> (raw)
This doesn't change anything, but I think it makes the code clearer.
It silences a smatch warning:
sound/pci/oxygen/oxygen_mixer.c +91 dac_mute_put(7) warn: add some parenthesis here?
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
Compile tested.
diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c
index f375b8a..28590b9 100644
--- a/sound/pci/oxygen/oxygen_mixer.c
+++ b/sound/pci/oxygen/oxygen_mixer.c
@@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl,
int changed;
mutex_lock(&chip->mutex);
- changed = !value->value.integer.value[0] != chip->dac_mute;
+ changed = (!value->value.integer.value[0]) != chip->dac_mute;
if (changed) {
chip->dac_mute = !value->value.integer.value[0];
chip->model.update_dac_mute(chip);
next reply other threads:[~2010-02-19 6:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 6:58 Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-02-19 8:29 [patch] oxygen: clean up. make precedence explicit Clemens Ladisch
2010-02-19 10:10 ` Dan Carpenter
[not found] ` <1266575610.31443.6.camel@thorin>
2010-02-19 11:29 ` Dan Carpenter
2010-02-19 16:58 ` Dan Carpenter
[not found] ` <1266584951.31443.15.camel@thorin>
2010-02-19 17:24 ` Clemens Ladisch
2010-02-19 20:08 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100219065856.GA17130@bicker \
--to=error27@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).