From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Graham Gower <graham.gower@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: Fix passing platform_data to ac97 bus users and fix a leak.
Date: Thu, 25 Mar 2010 16:09:32 +0000 [thread overview]
Message-ID: <20100325160932.GB3025@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4BAAACB4.6030303@gmail.com>
On Thu, Mar 25, 2010 at 10:52:12AM +1030, Graham Gower wrote:
> Mark, Liam,
>
> As requested, this patch removes the initial allocation of codec->ac97.
Please recheck SubmittingPatches - this'd end up in the changelog (and
now your changelog is empty so it's not clear what the actual problem is
any more). I've applied this with a changelog added and...
> }
> - if (card->dai_link[i].codec_dai->ac97_control) {
> + if (card->dai_link[i].codec_dai->ac97_control && codec->ac97) {
> snd_ac97_dev_add_pdata(codec->ac97,
> card->dai_link[i].cpu_dai->ac97_pdata);
...a comment here since otherwise it's not obvious why we're not
complaining about the missing codec->ac97 otherwise.
prev parent reply other threads:[~2010-03-25 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 4:29 [PATCH] ASoC: Fix passing platform_data to ac97 bus users and fix a leak Graham Gower
2010-03-24 9:23 ` Liam Girdwood
2010-03-24 13:06 ` Mark Brown
2010-03-25 0:22 ` Graham Gower
2010-03-25 8:55 ` Liam Girdwood
2010-03-25 16:09 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100325160932.GB3025@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=graham.gower@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox