From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Brown Subject: Re: [PATCH 1/4] pxa: add namespace on ssp Date: Thu, 22 Apr 2010 09:08:18 +0900 Message-ID: <20100422000817.GB22879@opensource.wolfsonmicro.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from opensource2.wolfsonmicro.com (opensource.wolfsonmicro.com [80.75.67.52]) by alsa0.perex.cz (Postfix) with ESMTP id 8D06E2439E for ; Thu, 22 Apr 2010 02:08:14 +0200 (CEST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Eric Miao Cc: alsa-devel@alsa-project.org, linux-arm-kernel , Haojian Zhuang , Liam Girdwood List-Id: alsa-devel@alsa-project.org On Thu, Apr 22, 2010 at 06:17:29AM +0800, Eric Miao wrote: > On Sat, Apr 17, 2010 at 1:34 PM, Haojian Zhuang > > In order to prevent code ambiguous, add namespace on functions in ssp driver. > Sorry I'm still not convinced that this is a necessary change, could > you point me to some place where there are naming conflicts? Oh, sorry - misread the patch that was being replied to. The issue is more around consistency and the fact that ssp_ is pretty short as it is about specific conflicts that exist. If the rest of the driver had been using ssp_ already I wouldn't have said anything but since currently exported symbols all use pxa2xx_ it seemed better to make newly exported ones match.