From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCH 1/5] ASoC: tlv320dac33: Fix for early interrupt in FIFO Mode1
Date: Fri, 23 Apr 2010 08:33:37 +0300 [thread overview]
Message-ID: <201004230833.38058.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1271953611.3228.435.camel@odin>
On Thursday 22 April 2010 19:26:51 ext Liam Girdwood wrote:
> > + /* Enable Alarm Threshold IRQ */
> > + msleep(2);
>
> Does this sleep depend on rate/frame_size in any way ?
It is actually depends on the alarm_threshold and the burst rate.
We only want to enable the interrupt, when the FIFO depth is higher than the
alarm threshold, thus we will not receive the extra interrupt.
I have now the corrected version.
Thanks,
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2010-04-23 5:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 13:57 [PATCH 0/5] ASoC: tlv320dac33: FIFO caused delay reporting and fixes Peter Ujfalusi
2010-04-22 13:57 ` [PATCH 1/5] ASoC: tlv320dac33: Fix for early interrupt in FIFO Mode1 Peter Ujfalusi
2010-04-22 16:26 ` Liam Girdwood
2010-04-23 5:33 ` Peter Ujfalusi [this message]
2010-04-22 13:57 ` [PATCH 2/5] ASoC: tlv320dac33: Skip calculations in FIFO Bypass mode Peter Ujfalusi
2010-04-22 13:57 ` [PATCH 3/5] ASoC: tlv320dac33: Change magic numbers used in Mode7 Peter Ujfalusi
2010-04-22 13:57 ` [PATCH 4/5] ASoC: tlv320dac33: Calculate the interface speed during bursts Peter Ujfalusi
2010-04-22 13:57 ` [PATCH 5/5] ASoC: tlv320dac33: FIFO caused delay reporting Peter Ujfalusi
2010-04-22 17:57 ` Liam Girdwood
2010-04-23 5:52 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004230833.38058.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox