From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: ext Mark Brown <broonie@opensource.wolfsonmicro.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 4/4] ASoC: tlv320dac33: Support for turning off the codec in BIAS_STANDBY
Date: Fri, 30 Apr 2010 12:45:38 +0300 [thread overview]
Message-ID: <201004301245.38913.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <20100430084100.GB28241@rakim.wolfsonmicro.main>
On Friday 30 April 2010 11:41:00 ext Mark Brown wrote:
> On Fri, Apr 30, 2010 at 10:31:55AM +0300, Peter Ujfalusi wrote:
> > When the codec is in STANDBY we can actually turn it off.
> > When the codec is off, than the associated regulator can be also turned
> > off (if the number of users on the regulator is 0).
>
> You can just set idle_bias_off in the CODEC and then the core will push
> you down into _BIAS_OFF.
Good idea. Needed some code movement, but works fine. Thanks.
>
> > There are few scenarios, which has to be taken care::
> > 1. Analog bypass caused BIAS_STANDBY -> BIAS_ON
> >
> > We need to power on the codec, and do the chip init, but we does not
> > need to execute the playback related configuration
>
> Moving the playback related configuration into events on the DAC widgets
> (or probably a supply connected to the DAC widgets) seems like a good
> move for a lot of these scenarios? The core will then take care of
> ensuring that the startup sequence for the playback is called for you
> and the states can do what they're supposed to more directly.
This is not working.
Actually it works, if we come from BIAS_OFF, but...
If I restart the playback fast (within asoc timeout for BIAS change), than the
widget will not get event (since it is still powered). This means that I can not
do the needed reconfiguration for the tlv320dac33 -> audio breaks.
I will keep the current logic, but move it a bit with the idle_bias_off change.
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
Péter
next prev parent reply other threads:[~2010-04-30 9:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 7:31 [PATCH 0/4] ASoC: tlv320dac33: Support for turning codec off Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 1/4] ASoC: tlv320dac33: Optimize power up, and restore Peter Ujfalusi
2010-04-30 7:37 ` Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 2/4] ASoC: tlv320dac33: Revised module loading, and DAC33 ID read Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 3/4] ASoC: tlv320dac33: Manage a pointer for snd_pcm_substream in private structure Peter Ujfalusi
2010-04-30 7:31 ` [PATCH 4/4] ASoC: tlv320dac33: Support for turning off the codec in BIAS_STANDBY Peter Ujfalusi
2010-04-30 8:41 ` Mark Brown
2010-04-30 9:45 ` Peter Ujfalusi [this message]
2010-04-30 9:56 ` Mark Brown
2010-04-30 10:10 ` Peter Ujfalusi
2010-04-30 10:23 ` [PATCH 4/4] ASoC: tlv320dac33: Support for?turning " Mark Brown
2010-04-30 10:55 ` [PATCH 4/4] ASoC: tlv320dac33: Support for turning " Peter Ujfalusi
2010-04-30 11:42 ` Mark Brown
2010-04-30 11:42 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201004301245.38913.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).