From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Liam@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH] ASoC: tlv320aic3x: Add platform data and reset gpio handling
Date: Wed, 5 May 2010 12:50:20 +0300 [thread overview]
Message-ID: <20100505125020.7f0a2c01.jhnikula@gmail.com> (raw)
In-Reply-To: <201005051235.55742.peter.ujfalusi@nokia.com>
On Wed, 5 May 2010 12:35:55 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> > err_enable:
> > regulator_bulk_free(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
> > err_get:
> > + regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
>
> This looks suspicious (disable after free?)
> On the other hand, is there a need to disable at all in error case?
>
Oops. How that went there. Thanks for noticing!
--
Jarkko
prev parent reply other threads:[~2010-05-05 9:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 8:13 [PATCH] ASoC: tlv320aic3x: Add platform data and reset gpio handling Jarkko Nikula
2010-05-05 9:35 ` Peter Ujfalusi
2010-05-05 9:50 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505125020.7f0a2c01.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=Liam@alsa-project.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).