From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org, lrg@slimlogic.co.uk
Subject: Re: [PATCH] ASoC: tlv320dac33: Use codec defaults for LOM/LOP and DAC power
Date: Thu, 6 May 2010 11:35:27 +0100 [thread overview]
Message-ID: <20100506103527.GD30491@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1273136665-3340-1-git-send-email-peter.ujfalusi@nokia.com>
On Thu, May 06, 2010 at 12:04:25PM +0300, Peter Ujfalusi wrote:
> Do not change the codec defaults for the following registers:
> 0x40, 0x41: Line output gains, do not use amplification
> 0x42: LOM/LOP Voltage hold, and selection
> 0x44: LOM inversion control
>
> It has been found, that the values configured to these registers
> can cause amplification, which can make the output of DAC33
> distorted.
>
> The codec reset values are considered safe in all environmnts.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-05-06 10:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-06 9:04 [PATCH] ASoC: tlv320dac33: Use codec defaults for LOM/LOP and DAC power Peter Ujfalusi
2010-05-06 10:35 ` Mark Brown [this message]
2010-05-06 14:02 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506103527.GD30491@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).