alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: ext Liam Girdwood <lrg@slimlogic.co.uk>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling
Date: Thu, 6 May 2010 12:08:18 +0300	[thread overview]
Message-ID: <201005061208.18169.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1273133875.2992.14.camel@odin>

On Thursday 06 May 2010 11:17:55 ext Liam Girdwood wrote:
> 
> I can add a message if required.

I think it is always a good idea to explain what, and why the change.
In this case the change is not that obvious.

Also all machines, which are using the tlv320aic3x should be aware, that if they 
do not have the reset GPIO (which they _should_), than they have to set the 
gpio_reset to -1, unless they want to request gpio0 in the tlv320aic3x driver 
for fun ;)

> 
> Thanks
> 
> Liam

-- 
Péter
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2010-05-06  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05 10:02 [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling Jarkko Nikula
2010-05-05 11:28 ` Mark Brown
2010-05-06  8:09 ` Peter Ujfalusi
2010-05-06  8:17   ` Liam Girdwood
2010-05-06  9:08     ` Peter Ujfalusi [this message]
2010-05-06  9:52       ` Mark Brown
2010-05-06 11:23         ` Peter Ujfalusi
2010-05-06 10:18   ` Jarkko Nikula
2010-05-06 14:05 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005061208.18169.peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).