From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: alsa-devel@alsa-project.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling
Date: Thu, 6 May 2010 13:18:35 +0300 [thread overview]
Message-ID: <20100506131835.a9a066eb.jhnikula@gmail.com> (raw)
In-Reply-To: <201005061109.34734.peter.ujfalusi@nokia.com>
On Thu, 6 May 2010 11:09:34 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> On Wednesday 05 May 2010 13:02:03 ext Jarkko Nikula wrote:
> > Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> >
> > ---
> >
> > v2:
> >
> > - Removed added regulator_bulk_disable brain fart from aic3x_i2c_probe
> > - Added comment to gpio_reset number in aic3x_pdata
>
> Would have been nice to have a commit message for this just in case.
> Something like this would do:
> Handle the reset GPIO within the codec driver in order to follow the startup
> protocol for the tlv320aic3x codecs.
>
> Can you Liam add this message (if Jarkko agrees)?
>
Yeah, Peter is right. Even this reset 'protocol' is business as usual,
reset is released after voltages are stabilized, this is kind of fix to
patch adding regulator support so the commit message is nice be there.
--
Jarkko
next prev parent reply other threads:[~2010-05-06 10:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 10:02 [PATCHv2] ASoC: tlv320aic3x: Add platform data and reset gpio handling Jarkko Nikula
2010-05-05 11:28 ` Mark Brown
2010-05-06 8:09 ` Peter Ujfalusi
2010-05-06 8:17 ` Liam Girdwood
2010-05-06 9:08 ` Peter Ujfalusi
2010-05-06 9:52 ` Mark Brown
2010-05-06 11:23 ` Peter Ujfalusi
2010-05-06 10:18 ` Jarkko Nikula [this message]
2010-05-06 14:05 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506131835.a9a066eb.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).