From: "Ville Syrjälä" <syrjala@sci.fi>
To: Hans de Goede <hdegoede@redhat.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/2] snd-es1968: Make hardware volume buttons an input device (rev2)
Date: Fri, 7 May 2010 00:08:19 +0300 [thread overview]
Message-ID: <20100506210819.GF6861@sci.fi> (raw)
In-Reply-To: <1272014803-10706-2-git-send-email-hdegoede@redhat.com>
On Fri, Apr 23, 2010 at 05:26:43AM -0400, Hans de Goede wrote:
> The hardware volume handling code in essence just detects key presses, and
> then does some hardcoded modification of the master volume based on which key
> is pressed.
>
> Clearly the right thing to do here is just report these keypresses to
> userspace and let userspace decide what to with them.
>
> This patch adds a Kconfig option which when enabled reports the volume
> buttons as keypresses using an input device. When enabled this option
> also gets rid of the ugly direct ac97 writes from the tasklet, the ac97lock
> and the need for using a tasklet in general.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Ville Syrjälä <syrjala@sci.fi>
Both SND_ES1968_INPUT=y and SND_ES1968_INPUT=n work fine on my Dell
Inspiron 7000.
--
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
next prev parent reply other threads:[~2010-05-06 21:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 9:26 [PATCH 1/2] snd-maestro3: Make hardware volume buttons an input device (rev2) Hans de Goede
2010-04-23 9:26 ` [PATCH 2/2] snd-es1968: " Hans de Goede
2010-05-06 21:08 ` Ville Syrjälä [this message]
2010-05-06 21:10 ` [PATCH 1/2] snd-maestro3: " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100506210819.GF6861@sci.fi \
--to=syrjala@sci.fi \
--cc=alsa-devel@alsa-project.org \
--cc=hdegoede@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).