From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>
Subject: Re: [PATCH RFC v1] ASoC: core: Support for limiting the volume
Date: Fri, 7 May 2010 11:05:12 +0100 [thread overview]
Message-ID: <20100507100511.GB21498@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <201005071303.53132.peter.ujfalusi@nokia.com>
On Fri, May 07, 2010 at 01:03:53PM +0300, Peter Ujfalusi wrote:
> I think:
> if (max <= mc->max) {
> mc->max = max;
> ret = 0;
> }
> Would be appropriate. We still report error, if the user asked out of limit
> gain, but we report success, if the limit has not been actually changed.
Yes, reporting an error if the limit is higher than is possible is
sensible.
prev parent reply other threads:[~2010-05-07 10:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 6:03 [PATCH RFC v1] ASoC: core: Support for limiting the volume Peter Ujfalusi
2010-05-07 7:26 ` Peter Ujfalusi
2010-05-07 9:56 ` Mark Brown
2010-05-07 10:03 ` Peter Ujfalusi
2010-05-07 10:05 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100507100511.GB21498@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).