From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: apatard@mandriva.com
Cc: alsa-devel@alsa-project.org, nico@fluxnic.net, saeed@marvell.com,
tbm@cyrius.com, linux-arm-kernel@lists.infradead.org,
lrg@slimlogic.co.uk
Subject: Re: [patch 0/5] kirkwood openrd client audio support - v3
Date: Wed, 26 May 2010 00:18:32 +0100 [thread overview]
Message-ID: <20100525231831.GA11785@sirena.org.uk> (raw)
In-Reply-To: <20100525122236.841941526@mandriva.com>
On Tue, May 25, 2010 at 02:22:36PM +0200, apatard@mandriva.com wrote:
> It's a new try to get merged kirkwood openrd client support.
> The changes are :
> - set window configuration according to dma address
> - namespaced all cs42l51 #define
> - modified cs42l51_dac_names array according to what proposed Mark Brown
> - use SOC_DOUBLE_TLV for mic boost
This looks mostly OK to me - I had a few comments on the CODEC driver
but they're fairly minor. It'd be good to get some input from the
Kirkwood guys, particularly with regard to the merge path here.
next prev parent reply other threads:[~2010-05-25 23:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-25 12:22 [patch 0/5] kirkwood openrd client audio support - v3 apatard
2010-05-25 12:22 ` [patch 1/5] orion/kirkwood: add audio functions apatard
2010-05-25 12:22 ` [patch 2/5] openrd-client: initialise audio apatard
2010-05-25 12:22 ` [patch 3/5] cs42l51: add asoc driver apatard
2010-05-25 22:51 ` Mark Brown
2010-05-26 8:20 ` Arnaud Patard
2010-05-27 0:52 ` Mark Brown
2010-05-25 12:22 ` [patch 4/5] orion/kirkwood: Add i2s support apatard
2010-05-26 0:31 ` Nicolas Pitre
2010-05-26 5:15 ` saeed bishara
2010-05-26 16:55 ` Nicolas Pitre
2010-05-26 8:25 ` Arnaud Patard
2010-05-26 17:02 ` Nicolas Pitre
2010-05-25 12:22 ` [patch 5/5] kirkwood: Add audio support to openrd client platforms apatard
2010-05-25 23:18 ` Mark Brown [this message]
2010-05-26 1:10 ` [patch 0/5] kirkwood openrd client audio support - v3 Nicolas Pitre
2010-05-26 2:31 ` Mark Brown
2010-05-26 2:49 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100525231831.GA11785@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=apatard@mandriva.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=nico@fluxnic.net \
--cc=saeed@marvell.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).