From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org
Cc: "john.cooper@third-harmonic.com" <john.cooper@third-harmonic.com>,
"chasedouglas@gmail.com" <chasedouglas@gmail.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
ext Ryan Mallon <ryan@bluewatersys.com>,
"buytenh@wantstofly.org" <buytenh@wantstofly.org>,
"r&d4@dave-tech.it" <r&d4@dave-tech.it>,
"hartleys@visionengravers.com" <hartleys@visionengravers.com>,
"lrg@slimlogic.co.uk" <lrg@slimlogic.co.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"dhuggins@cs.cmu.edu" <dhuggins@cs.cmu.edu>
Subject: Re: [RFC PATCH v2 1/3] ep93xx i2s audio driver
Date: Wed, 26 May 2010 14:16:49 +0300 [thread overview]
Message-ID: <201005261416.49362.peter.ujfalusi@nokia.com> (raw)
In-Reply-To: <1274850588-30460-2-git-send-email-ryan@bluewatersys.com>
Hi,
On Wednesday 26 May 2010 08:09:46 ext Ryan Mallon wrote:
> Add ep93xx i2s audio driver
..
> +static void ep93xx_i2s_disable(struct ep93xx_i2s_info *info)
> +{
> + int i;
> +
> + /* Disable fifos */
> + for (i = 0; i < 3; i++) {
> + ep93xx_i2s_write_reg(info, EP93XX_I2S_RX0EN + (i * 4), 0);
> + ep93xx_i2s_write_reg(info, EP93XX_I2S_TX0EN + (i * 4), 0);
> + }
> +
> + /* Disable i2s */
> + ep93xx_i2s_write_reg(info, EP93XX_I2S_GLCTRL, 0);
> +
> + /* Disable clocks */
> + clk_disable(info->lrclk);
> + clk_disable(info->sclk);
> + clk_disable(info->mclk);
> +}
I think this will break the other stream in duplex case, since you stop both
FIFOs, and also disable the clocks.
Does the ep93xx supports duplex audio?
--
Péter
next prev parent reply other threads:[~2010-05-26 11:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 5:09 [RFC PATCH v2 0/3] ep93xx i2s audio Ryan Mallon
2010-05-26 5:09 ` [RFC PATCH v2 1/3] ep93xx i2s audio driver Ryan Mallon
2010-05-26 11:07 ` Liam Girdwood
2010-05-26 11:16 ` Peter Ujfalusi [this message]
2010-05-26 12:54 ` Chase Douglas
2010-05-26 13:08 ` Lothar Waßmann
2010-05-27 2:13 ` Mark Brown
2010-05-26 5:09 ` [RFC PATCH v2 2/3] ep93xx i2s core support Ryan Mallon
2010-05-26 5:09 ` [RFC PATCH v2 3/3] ep93xx i2s audio snapper cl15 support Ryan Mallon
2010-05-26 12:59 ` [RFC PATCH v2 0/3] ep93xx i2s audio Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005261416.49362.peter.ujfalusi@nokia.com \
--to=peter.ujfalusi@nokia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=buytenh@wantstofly.org \
--cc=chasedouglas@gmail.com \
--cc=dhuggins@cs.cmu.edu \
--cc=hartleys@visionengravers.com \
--cc=john.cooper@third-harmonic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@slimlogic.co.uk \
--cc=r&d4@dave-tech.it \
--cc=ryan@bluewatersys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).