Re: Crash 2.6.32.x, Echo 3G, Alsa, SCSI

[Giuliano Pochini <pochini@shiny.it>]

On Mon, 31 May 2010 15:05:08 -0400
"F. Heitkamp" <heitkamp@ameritech.net> wrote:

> On 02/02/10 17:09, Giuliano Pochini wrote:
> > On Tue, 02 Feb 2010 16:30:27 +0100
> > Clemens Ladisch<clemens@ladisch.de>  wrote:
> >
> >    
> >> Frederick V Heitkamp wrote:
> >>      
> >>> Repeatable Hard Crash.
> >>> What else do I need to provide?
[...]
> > Signed-off-by: Giuliano Pochini<pochini@shiny.it>
> >
> > --- alsa-driver-1.0.22.1/alsa-kernel/pci/echoaudio/echoaudio.c__orig	2010-02-02 22:37:33.000000000 +0100
> > +++ alsa-driver-1.0.22.1/alsa-kernel/pci/echoaudio/echoaudio.c	2010-02-02 22:44:03.000000000 +0100
> > @@ -1821,7 +1821,9 @@ static irqreturn_t snd_echo_interrupt(in
> >   	/* The hardware doesn't tell us which substream caused the irq,
> >   	thus we have to check all running substreams. */
> >   	for (ss = 0; ss<  DSP_MAXPIPES; ss++) {
> > -		if ((substream = chip->substream[ss])) {
> > +		substream = chip->substream[ss];
> > +		if (substream&&  ((struct audiopipe *)substream->runtime->
> > +				private_data)->state == PIPE_STATE_STARTED) {
> >   			period = pcm_pointer(substream) /
> >   				substream->runtime->period_size;
> >   			if (period != chip->last_period[ss]) {
> >
> >
> >    
> I've tried some newer kernels.  Still having problems with the echo 3G.  
> This is kernel version:
> 2.6.32.13.  The above patches posted to the linux kernel list seemed to 
> get rid of the crashes, but evidently did not go into the main kernel tree.

Indeed. I've just checked 2.6.33 and the patch isn't there. It's in 2.6.34.

If you need 2.6.32.13 you can apply the above patch to the kernel tree or
download ftp://ftp.alsa-project.org/pub/driver/alsa-driver-1.0.23.tar.bz2,
otherwise just use the latest kernel.


-- 
Giuliano.