From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wan ZongShun <mcuos.com@gmail.com>
Cc: alsa-devel <alsa-devel@alsa-project.org>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 1/3] ALSA/NUC900: Fix some codes according to Liam for nuc900 alsa driver.
Date: Tue, 1 Jun 2010 11:20:05 +0100 [thread overview]
Message-ID: <20100601102005.GA863@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <4C0474F3.3050503@gmail.com>
On Tue, Jun 01, 2010 at 10:48:19AM +0800, Wan ZongShun wrote:
> Dear Liam & Mark,
>
> This patch is to fix some codes according to
> Liam for nuc900 alsa driver.
So, these changes look like they're fine but since you've not provided a
changelog it's hard to tell for sure. It also looks like you've got two
different changes in here, some of the code is adjusting the delays used
between register writes in reset while other bits change the code over
to using the standard method for checking for substream type.
As I said to you yesterday please do read and follow the instructions in
Documentation/SubmittingPatches - in particular, you need to include a
proper changelog in your mail and you shouldn't have any "Dear X" or
similar.
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
You're missing a space between your name and the e-mail address too.
prev parent reply other threads:[~2010-06-01 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4C0474F3.3050503@gmail.com>
2010-06-01 9:04 ` [PATCH 1/3] ALSA/NUC900: Fix some codes according to Liam for nuc900 alsa driver Liam Girdwood
2010-06-01 10:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601102005.GA863@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=lrg@slimlogic.co.uk \
--cc=mcuos.com@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).