From: Jarkko Nikula <jhnikula@gmail.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"tony@atomide.com" <tony@atomide.com>,
"broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>,
"Valentin Eduardo (Nokia-D/Helsinki)"
<eduardo.valentin@nokia.com>,
"Nurkkala Eero.An (EXT-Offcode/Oulu)"
<ext-Eero.Nurkkala@nokia.com>,
ext@alsa-project.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams
Date: Tue, 1 Jun 2010 10:38:28 +0300 [thread overview]
Message-ID: <20100601103828.55e7b394.jhnikula@gmail.com> (raw)
In-Reply-To: <201006010947.09640.peter.ujfalusi@nokia.com>
On Tue, 1 Jun 2010 09:47:09 +0300
Peter Ujfalusi <peter.ujfalusi@nokia.com> wrote:
> I like the following naming:
> omap_mcbsp_hwrule_min_buffersize()
> omap_mcbsp_hwrule_max_periodsize()
>
Looks clear to me.
> Also, I think there is no point to limit the lower period size in threshold mode
> to 32, so I will remove that as well I think.
>
What was the reason why period size cannot be bigger than threshold?
This constraint was there before your patch but I don't remember reason
for it.
Should it be opposite that period size cannot be smaller than threshold?
--
Jarkko
next prev parent reply other threads:[~2010-06-01 7:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 8:16 [RFC PATCH 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 1/5] OMAP: McBSP: Function to query the FIFO size Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 2/5] OMAP3: McBSP: Change the way how the FIFO is handled Peter Ujfalusi
2010-05-31 17:41 ` Nishanth Menon
2010-06-01 6:59 ` Peter Ujfalusi
2010-06-02 4:24 ` Nishanth Menon
2010-05-31 8:16 ` [RFC PATCH 3/5] OMAP3: McBSP: Use the port's buffer_size when calculating tx delay Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 4/5] ASoC: omap-mcbsp: Save, and use wlen for threshold configuration Peter Ujfalusi
2010-05-31 8:16 ` [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams Peter Ujfalusi
2010-05-31 8:41 ` Peter Ujfalusi
2010-05-31 10:00 ` [alsa-devel] " Liam Girdwood
2010-05-31 11:57 ` Peter Ujfalusi
2010-06-01 6:38 ` Jarkko Nikula
2010-06-01 6:47 ` Peter Ujfalusi
2010-06-01 7:38 ` Jarkko Nikula [this message]
2010-06-01 8:07 ` Peter Ujfalusi
2010-06-01 8:19 ` Peter Ujfalusi
2010-06-01 9:29 ` Jarkko Nikula
2010-06-01 10:30 ` Peter Ujfalusi
2010-06-01 11:20 ` [alsa-devel] " Jarkko Nikula
2010-06-01 11:34 ` Peter Ujfalusi
-- strict thread matches above, loose matches on Subject: below --
2010-05-31 8:03 [RFC PATCH 0/5] OMAP/ASoC: McBSP: FIFO handling related fixes Peter Ujfalusi
2010-05-31 8:03 ` [RFC PATCH 5/5] ASoC: omap-mcbsp: Place correct constraints for streams Peter Ujfalusi
2010-05-31 8:09 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601103828.55e7b394.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=eduardo.valentin@nokia.com \
--cc=ext-Eero.Nurkkala@nokia.com \
--cc=ext@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=peter.ujfalusi@nokia.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).