alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] ASoC/kirkwood: patch for the useless 'break' removal.
       [not found] <4C06105B.2060702@gmail.com>
@ 2010-06-05  7:04 ` Wan ZongShun
  2010-06-07 12:53   ` Liam Girdwood
  0 siblings, 1 reply; 3+ messages in thread
From: Wan ZongShun @ 2010-06-05  7:04 UTC (permalink / raw)
  To: alsa-devel, Liam Girdwood, Mark Brown, zswan

Hi Mark,

How about this patch?
My other patch seem to be applied, but this one still be hung.

在 2010年6月2日 下午4:03,Wan ZongShun <mcuos.com@gmail.com> 写道:
> This patch to remove the 'break;', when the 'switch' jumps to
> the 'default' branch, the 'return -EINVAL' will be return with
> a error number, so the 'break;' code never be run, it is unuseful
> and should be removed here.
>
>
> Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>
> ---
>  sound/soc/kirkwood/kirkwood-i2s.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
> index 0adc597..0fdc7db 100644
> --- a/sound/soc/kirkwood/kirkwood-i2s.c
> +++ b/sound/soc/kirkwood/kirkwood-i2s.c
> @@ -296,7 +296,6 @@ static int kirkwood_i2s_rec_trigger(struct snd_pcm_substream *substream,
>
>        default:
>                return -EINVAL;
> -               break;
>        }
>
>        return 0;
> --
> 1.6.3.3
>



-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@lists.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@googlegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@gmail.com
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC/kirkwood: patch for the useless 'break' removal.
  2010-06-05  7:04 ` [PATCH] ASoC/kirkwood: patch for the useless 'break' removal Wan ZongShun
@ 2010-06-07 12:53   ` Liam Girdwood
  2010-06-07 13:28     ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Liam Girdwood @ 2010-06-07 12:53 UTC (permalink / raw)
  To: Wan ZongShun; +Cc: alsa-devel, Mark Brown, zswan

On Sat, 2010-06-05 at 15:04 +0800, Wan ZongShun wrote:
> Hi Mark,
> 
> How about this patch?
> My other patch seem to be applied, but this one still be hung.
> 
> 在 2010年6月2日 下午4:03,Wan ZongShun <mcuos.com@gmail.com> 写道:
> > This patch to remove the 'break;', when the 'switch' jumps to
> > the 'default' branch, the 'return -EINVAL' will be return with
> > a error number, so the 'break;' code never be run, it is unuseful
> > and should be removed here.
> >
> >
> > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>

Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC/kirkwood: patch for the useless 'break' removal.
  2010-06-07 12:53   ` Liam Girdwood
@ 2010-06-07 13:28     ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2010-06-07 13:28 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: alsa-devel, zswan, Wan ZongShun

On Mon, Jun 07, 2010 at 01:53:21PM +0100, Liam Girdwood wrote:
> On Sat, 2010-06-05 at 15:04 +0800, Wan ZongShun wrote:

> > > Signed-off-by: Wan ZongShun<mcuos.com@gmail.com>

> Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>

Applied, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-06-07 13:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <4C06105B.2060702@gmail.com>
2010-06-05  7:04 ` [PATCH] ASoC/kirkwood: patch for the useless 'break' removal Wan ZongShun
2010-06-07 12:53   ` Liam Girdwood
2010-06-07 13:28     ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).