alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* Re: [sdr-widget] UAC2 sampling freq setting
       [not found] <a3ec17f9-b3a9-42f1-86b9-081b6f234faa@6g2000prg.googlegroups.com>
@ 2010-06-11  7:02 ` Daniel Mack
  0 siblings, 0 replies; only message in thread
From: Daniel Mack @ 2010-06-11  7:02 UTC (permalink / raw)
  To: Alex Lee; +Cc: alsa-devel

(Moving this discussion from sdr-widget to alsa-devel. Can't Cc: the
 original mailing list as it forbids cross-posting)

On Thu, Jun 10, 2010 at 09:36:48PM -0700, Alex Lee wrote:
> I studied the driver source again and it becomes apparent that the
> driver only looks at the MIN value of the triplet (MIN, MAX, RES).  It
> does not take into consideration of the MAX and the RES in each
> triplet.

For samplerates it does that, yes.

> The driver calculates its own MIN and MAX values by going through all
> the triplets in the clock source.  In the present firmware, we only
> have ONE triplet in each clock source, with:
> 
> # of triplets = 1 (2 byte value)
> MIN  48000
> MAX 96000
> RES 48000

Ah, that's a corner case I didn't see. I'll fix this.

> in accordance with the UAC2 specs.  The present driver code expects:
> 
> # of triplets = 2  (2 byte value)
> triplet 1:
> 
> MIN  48000   MAX 48000 RES 00000
> 
> triplet 2:
> 
> MIN 96000 MAX 96000 RES 00000

Yes, that's right. All firmware code I've seen so far also has a triplet
for each discrete sample rate.

> Thus the present driver cannot decode the 1st case above correctly,
> and only get the 48khz value.
> 
> I will update the firmware to cater to the 2nd case above and we
> should have the 96khz back :-)

Ok, fair fix. I'll make sure future versions of the driver also support
the other approach.

Thanks,
Daniel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-11  7:02 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <a3ec17f9-b3a9-42f1-86b9-081b6f234faa@6g2000prg.googlegroups.com>
2010-06-11  7:02 ` [sdr-widget] UAC2 sampling freq setting Daniel Mack

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).