From: Daniel Mack <daniel@caiaq.de>
To: Clemens Ladisch <clemens@ladisch.de>
Cc: Alex Lee <alexlee188@gmail.com>,
tiwai@suse.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly
Date: Fri, 11 Jun 2010 17:18:29 +0200 [thread overview]
Message-ID: <20100611151829.GE17833@buzzloop.caiaq.de> (raw)
In-Reply-To: <4C1252F1.20809@ladisch.de>
On Fri, Jun 11, 2010 at 05:14:57PM +0200, Clemens Ladisch wrote:
> Daniel Mack wrote:
> > On Fri, Jun 11, 2010 at 10:59:44PM +0800, Alex Lee wrote:
> > > If the device has a variable clock, it may report a RES of only 1. So you
> > > may end up with thousands (and even millions) of sample rates. It might be
> > > better to have separate code to cater to discrete clocks vs variable clocks.
> >
> > AFAIK, ALSA can[...] cope with that [...]. Am I right?
>
> Yes; set fp->rates to SNDRV_PCM_RATE_CONTINUOUS to allow all rates between
> fp->rate_min and fp->rate_max. See, for example, parse_audio_format_rates_v1.
Ah, ok. So we should we do this for all USB devices that report a RES
value of 1. I'll respin this series then. Thanks!
Daniel
next prev parent reply other threads:[~2010-06-11 15:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-11 13:33 usb-audio: some UAC2 fixes Daniel Mack
2010-06-11 13:33 ` [PATCH 1/4] ALSA: usb-audio: add check for faulty clock in parse_audio_format_rates_v2() Daniel Mack
2010-06-11 13:33 ` [PATCH 2/4] ALSA: usb-audio: fix control messages for USB_RECIP_INTERFACE Daniel Mack
2010-06-11 13:33 ` [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly Daniel Mack
[not found] ` <AANLkTin3LMCu_f2emsh6kAT8H6G3zKF8Ud-ZUMpZjbmg@mail.gmail.com>
2010-06-11 15:04 ` Daniel Mack
2010-06-11 15:14 ` Clemens Ladisch
2010-06-11 15:18 ` Daniel Mack [this message]
2010-06-11 15:34 ` [PATCH 1/4] ALSA: usb-audio: add check for faulty clock in parse_audio_format_rates_v2() Daniel Mack
2010-06-11 16:10 ` Takashi Iwai
2010-06-11 15:34 ` [PATCH 2/4] ALSA: usb-audio: fix control messages for USB_RECIP_INTERFACE Daniel Mack
2010-06-11 15:34 ` [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly Daniel Mack
2010-06-11 15:43 ` Takashi Iwai
2010-06-11 15:46 ` Daniel Mack
2010-06-11 15:54 ` Takashi Iwai
2010-06-11 15:34 ` [PATCH 4/4] ALSA: usb-audio: fix UAC2 control value queries Daniel Mack
2010-06-11 15:18 ` [PATCH 3/4] ALSA: usb-audio: parse UAC2 sample rate ranges correctly Mark Brown
2010-06-14 12:41 ` Daniel Mack
2010-06-11 13:33 ` [PATCH 4/4] ALSA: usb-audio: fix UAC2 control value queries Daniel Mack
2010-06-11 13:51 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100611151829.GE17833@buzzloop.caiaq.de \
--to=daniel@caiaq.de \
--cc=alexlee188@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).